From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Nikiforov <void@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v8] base64: fix decoder output buffer overrun (reads)
Date: Fri, 19 Mar 2021 15:47:54 +0000 [thread overview]
Message-ID: <20210319154754.lk4nkj7dublrfczs@tarantool.org> (raw)
In-Reply-To: <7214add2c7f2a86265a5e08f2184029a19fc184d.1615283860.git.void@tarantool.org>
Hello,
On 09 мар 12:59, Sergey Nikiforov via Tarantool-patches wrote:
> Was caught by base64 test with enabled ASAN.
>
> It also caused data corruption - garbage instead of "extra bits" was
> saved into state->result if there was no space in output buffer.
>
> Decode state removed along with helper functions.
>
> Added test for "zero-sized output buffer" case.
>
> Fixes: #3069
I think we should stop it.
LGTM.
I've checked your patch into 1.10, 2.6, 2.7 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2021-03-19 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 9:59 Sergey Nikiforov via Tarantool-patches
2021-03-12 14:27 ` Alexander Turenko via Tarantool-patches
2021-03-14 16:23 ` Vladislav Shpilevoy via Tarantool-patches
2021-03-19 15:47 ` Kirill Yukhin via Tarantool-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210319154754.lk4nkj7dublrfczs@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=void@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v8] base64: fix decoder output buffer overrun (reads)' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox