From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 807B16EC56; Fri, 19 Mar 2021 18:47:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 807B16EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616168876; bh=M3TeIsxnYFhhOqxhmxkUuSS1lSUxjPDR2FPLhCsO+4A=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lDTnFyrZjLp8bYHaZDvPJhMP8vNf3RvROMU1M1IaZigi4IhfN3sRqrs5a0U9ukO4D Z80EDPJm8nOLUJNQ1TFu3YqcnX+87Fb58jQCA6/OKoRfFlIPfhBOBIcDvnukREnsLv fKsi+UHlyc/ToyjbY0kH7/+tpZ5A/ESKse6BEpIM= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7FC796EC56 for ; Fri, 19 Mar 2021 18:47:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7FC796EC56 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1lNHLu-0001eW-GT; Fri, 19 Mar 2021 18:47:54 +0300 Date: Fri, 19 Mar 2021 15:47:54 +0000 To: Sergey Nikiforov Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy , Alexander Turenko Message-ID: <20210319154754.lk4nkj7dublrfczs@tarantool.org> References: <7214add2c7f2a86265a5e08f2184029a19fc184d.1615283860.git.void@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7214add2c7f2a86265a5e08f2184029a19fc184d.1615283860.git.void@tarantool.org> User-Agent: NeoMutt/20170113 (1.7.2) X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F19D4B90E2C0E110A6B701D7D268243E19182A05F5380850401F62AAEA9699632086348EAC850CCCB251754F13CE4DD924C40DDAF728574921 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BC4B0F5721B555078638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C81A23F326053F827D86406AC165DE3BCAAF3B56A398EDEB1A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7BE1EAEA492AEE04CD32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED62991661749BA6B97735B1E7B660A538F4BFCD04E86FAF290E2D7E9C4E3C761E06A7089D37D7C0E48F6CA18204E546F3947C616AD31D0D18CD5C6D8C47C27EEC5E9FC8A9BA7A39EFB7666BA297DBC24807EA089D37D7C0E48F6C8AA50765F790063784234279671F8D0CEFF80C71ABB335746BA297DBC24807EA27F269C8F02392CD6143B1329D1CCA5627F269C8F02392CD5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D434D93F24555E5A3355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5BF196D0F76E80A244736C2970E1E1FE3ECA7DF61EFA14BA8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F1257DC9690AEBA1224272EC7F28B8D8E28C0CF2515CA2EF244058C4F96C81C5DC1D3F7D34FF48BE1D7E09C32AA3244CA5D0238F2C2AF5210C016B3618B3F69FF165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKyJYJ15DtIsE9WBZB0MaA== X-Mailru-Sender: 05EB39F83D09414F9B5D7F52D7CDFDD2B71EAD1C9C5C80A726D2E05F33B653B4BC1F0997A9148D22CA16B95394F0DD5CE99530A0C0F27B5268329DCED823713783C0E760C018FF54112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v8] base64: fix decoder output buffer overrun (reads) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kirill Yukhin via Tarantool-patches Reply-To: Kirill Yukhin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, On 09 мар 12:59, Sergey Nikiforov via Tarantool-patches wrote: > Was caught by base64 test with enabled ASAN. > > It also caused data corruption - garbage instead of "extra bits" was > saved into state->result if there was no space in output buffer. > > Decode state removed along with helper functions. > > Added test for "zero-sized output buffer" case. > > Fixes: #3069 I think we should stop it. LGTM. I've checked your patch into 1.10, 2.6, 2.7 and master. -- Regards, Kirill Yukhin