Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>,
	Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT
Date: Tue, 16 Mar 2021 15:22:04 +0300	[thread overview]
Message-ID: <20210316122204.GQ9042@tarantool.org> (raw)
In-Reply-To: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org>

I've checked the patch into 1.10, 2.6, 2.7 and master.

On 12.03.21, Igor Munkin wrote:
> After porting LuaJIT build system to CMake in commit
> 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build
> system'), its build options are not fully maintained in Tarantool. E.g.
> several compile flags, such as -fomit-frame-pointer, are set within
> LuaJIT CMake machinery and there is no way to tweak them outside. As a
> result ASAN + LSAN build in Tarantool CI[1] reports new leaks related to
> LuaJIT runtime, but there is none of them actually (no source code
> changes are made in scope of the applied patchset). Hence it was decided
> to consider all LuaJIT related warnings as false positives for now and
> suppress them until #5878 is resolved.
> [1]: https://github.com/tarantool/tarantool/runs/1999839396
> Follows up #4862
> Relates to #5878
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> This is a temporary solution, until #5878 is resolved. BTW, it looks
> like a ASAN/LSAN problem since, running it with fast_unwind_on_malloc=0
> doesn't make CI green and otherwise I have no idea why
> -fno-omit-frame-pointer is obligatory for sanitizers (I found not a
> single word in Google sanitizers docs regarding it). Though there is no
> problems on the stable branches other than 1.10, I believe this patch
> should be applied to all branches containing
> 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build
> system') to reduce the chance of unexpected CI breakage either on
> working or on stable branch.
> Issues:
> * https://github.com/tarantool/tarantool/issues/4862
> * https://github.com/tarantool/tarantool/issues/5878
> Branches: one with the patch and another providing CI is green on 1.10
> * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit
> * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit-1.10
>  asan/lsan.supp | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)


> -- 
> 2.25.0

Best regards,

      parent reply	other threads:[~2021-03-16 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 20:01 Igor Munkin via Tarantool-patches
2021-03-15 13:41 ` Alexander V. Tikhonov via Tarantool-patches
2021-03-15 15:31   ` Igor Munkin via Tarantool-patches
2021-03-16 11:45 ` Kirill Yukhin via Tarantool-patches
2021-03-16 12:18   ` Igor Munkin via Tarantool-patches
2021-03-16 12:22 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210316122204.GQ9042@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=imun@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox