From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7B4DA6EC56; Tue, 16 Mar 2021 15:22:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7B4DA6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615897333; bh=ocH+JDYPmPoI/um7sczzjqKll8uVIanBLP+9sIa9OGk=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ZGKReKKZBGNxgSOvSxmA8U52PP9mWUQ997Y5kZB0/sRtY48ewoMEIYlS+WEPcICMq 5n/kgiZ3qtHpTeRZu5jZiSaQmLXsju4jVi9Png7uPQTLdv+brsu6k0hNzMjN0hVHBb 7b+KwZuJ5P9C2sABSyxdbRwbbRxkopto+rtiQrHE= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 063FC6EC56 for ; Tue, 16 Mar 2021 15:22:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 063FC6EC56 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lM8iB-0005z0-PL; Tue, 16 Mar 2021 15:22:12 +0300 Date: Tue, 16 Mar 2021 15:22:04 +0300 To: "Alexander V. Tikhonov" , Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210316122204.GQ9042@tarantool.org> References: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B227B6855B2F1ABFAB31FADE3C60B02DF00894C459B0CD1B98FAF1E56318267DBA33C12586D92CCB328383AC1A7F5350BB58C0E165F9F46AE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7646B74825E00C605EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FACF2191C0719DEE8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496F1DA3683A83CA49DD45F99E455803D598A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C224902CFACCC19C6E7D3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CB3E4D57BB3B05F1143847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5862B9D04B5329C86D00CD781CF6DD4FC4BB4A1B3F606AD9BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF57E6F58AF8389D0094305912AEE428932B0262C7D956247C3972A09498C77A67A1D7E09C32AA3244CF62F788A70E69AE23BAEE12AC475E18624AF4FAF06DA24FD927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0lXEOP4TbAkFg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822750FB1D68D306FB191BBD62F25BE906AA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" I've checked the patch into 1.10, 2.6, 2.7 and master. On 12.03.21, Igor Munkin wrote: > After porting LuaJIT build system to CMake in commit > 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build > system'), its build options are not fully maintained in Tarantool. E.g. > several compile flags, such as -fomit-frame-pointer, are set within > LuaJIT CMake machinery and there is no way to tweak them outside. As a > result ASAN + LSAN build in Tarantool CI[1] reports new leaks related to > LuaJIT runtime, but there is none of them actually (no source code > changes are made in scope of the applied patchset). Hence it was decided > to consider all LuaJIT related warnings as false positives for now and > suppress them until #5878 is resolved. > > [1]: https://github.com/tarantool/tarantool/runs/1999839396 > > Follows up #4862 > Relates to #5878 > > Signed-off-by: Igor Munkin > --- > > This is a temporary solution, until #5878 is resolved. BTW, it looks > like a ASAN/LSAN problem since, running it with fast_unwind_on_malloc=0 > doesn't make CI green and otherwise I have no idea why > -fno-omit-frame-pointer is obligatory for sanitizers (I found not a > single word in Google sanitizers docs regarding it). Though there is no > problems on the stable branches other than 1.10, I believe this patch > should be applied to all branches containing > 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build > system') to reduce the chance of unexpected CI breakage either on > working or on stable branch. > > Issues: > * https://github.com/tarantool/tarantool/issues/4862 > * https://github.com/tarantool/tarantool/issues/5878 > Branches: one with the patch and another providing CI is green on 1.10 > * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit > * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit-1.10 > > asan/lsan.supp | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > -- > 2.25.0 > -- Best regards, IM