Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module
@ 2021-03-10  9:39 Sergey Kaplun via Tarantool-patches
  2021-03-11  8:05 ` Alexander Turenko via Tarantool-patches
  0 siblings, 1 reply; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2021-03-10  9:39 UTC (permalink / raw)
  To: Alexander Turenko, Alexander V . Tikhonov; +Cc: tarantool-patches

LuaJIT built-in misc was introduced via
tarantool/tarantool@e5039742eba89936bf2f8c5aebc8f21c810710d5
(luajit: bump new version) in Tarantool and via
tarantool/luajit@5a61e1ab54b5c66bfebd836db1ac47996611e065
(misc: add C and Lua API for platform metrics) in LuaJIT fork.

Follows up tarantool/tarantool#5187
---
Branch: https://github.com/tarantool/test-run/tree/skaplun/gh-noticket-add-misc-bultin-in-pretest-clean

 pretest_clean.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pretest_clean.lua b/pretest_clean.lua
index 9b5ac9d..8ea07e0 100644
--- a/pretest_clean.lua
+++ b/pretest_clean.lua
@@ -264,6 +264,7 @@ local function clean()
         json = true,
         log = true,
         math = true,
+        misc = true,
         msgpack = true,
         msgpackffi = true,
         ['net.box'] = true,
-- 
2.28.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module
  2021-03-10  9:39 [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module Sergey Kaplun via Tarantool-patches
@ 2021-03-11  8:05 ` Alexander Turenko via Tarantool-patches
  2021-03-11  8:42   ` Sergey Kaplun via Tarantool-patches
  0 siblings, 1 reply; 4+ messages in thread
From: Alexander Turenko via Tarantool-patches @ 2021-03-11  8:05 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

On Wed, Mar 10, 2021 at 12:39:05PM +0300, Sergey Kaplun wrote:
> LuaJIT built-in misc was introduced via
> tarantool/tarantool@e5039742eba89936bf2f8c5aebc8f21c810710d5
> (luajit: bump new version) in Tarantool and via
> tarantool/luajit@5a61e1ab54b5c66bfebd836db1ac47996611e065
> (misc: add C and Lua API for platform metrics) in LuaJIT fork.
> 
> Follows up tarantool/tarantool#5187
> ---
> Branch: https://github.com/tarantool/test-run/tree/skaplun/gh-noticket-add-misc-bultin-in-pretest-clean
> 
>  pretest_clean.lua | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/pretest_clean.lua b/pretest_clean.lua
> index 9b5ac9d..8ea07e0 100644
> --- a/pretest_clean.lua
> +++ b/pretest_clean.lua
> @@ -264,6 +264,7 @@ local function clean()
>          json = true,
>          log = true,
>          math = true,
> +        misc = true,
>          msgpack = true,
>          msgpackffi = true,
>          ['net.box'] = true,

The module is loaded by default, so I would add it to 'allowed_globals'
too.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module
  2021-03-11  8:05 ` Alexander Turenko via Tarantool-patches
@ 2021-03-11  8:42   ` Sergey Kaplun via Tarantool-patches
  2021-03-11 12:33     ` Alexander Turenko via Tarantool-patches
  0 siblings, 1 reply; 4+ messages in thread
From: Sergey Kaplun via Tarantool-patches @ 2021-03-11  8:42 UTC (permalink / raw)
  To: Alexander Turenko; +Cc: tarantool-patches

Hi!

On 11.03.21, Alexander Turenko wrote:
> On Wed, Mar 10, 2021 at 12:39:05PM +0300, Sergey Kaplun wrote:
> > LuaJIT built-in misc was introduced via
> > tarantool/tarantool@e5039742eba89936bf2f8c5aebc8f21c810710d5
> > (luajit: bump new version) in Tarantool and via
> > tarantool/luajit@5a61e1ab54b5c66bfebd836db1ac47996611e065
> > (misc: add C and Lua API for platform metrics) in LuaJIT fork.
> > 
> > Follows up tarantool/tarantool#5187
> > ---
> > Branch: https://github.com/tarantool/test-run/tree/skaplun/gh-noticket-add-misc-bultin-in-pretest-clean
> > 
> >  pretest_clean.lua | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/pretest_clean.lua b/pretest_clean.lua
> > index 9b5ac9d..8ea07e0 100644
> > --- a/pretest_clean.lua
> > +++ b/pretest_clean.lua
> > @@ -264,6 +264,7 @@ local function clean()
> >          json = true,
> >          log = true,
> >          math = true,
> > +        misc = true,
> >          msgpack = true,
> >          msgpackffi = true,
> >          ['net.box'] = true,
> 
> The module is loaded by default, so I would add it to 'allowed_globals'
> too.

Thanks, my bad! Fixed and force-pushed to the branch. See the iterative
patch below:

===================================================================
diff --git a/pretest_clean.lua b/pretest_clean.lua
index 8ea07e0..446ecf2 100644
--- a/pretest_clean.lua
+++ b/pretest_clean.lua
@@ -155,6 +155,7 @@ local function clean()
         io = true,
         jit = true,
         math = true,
+        misc = true,
         os = true,
         package = true,
         string = true,
===================================================================

-- 
Best regards,
Sergey Kaplun

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module
  2021-03-11  8:42   ` Sergey Kaplun via Tarantool-patches
@ 2021-03-11 12:33     ` Alexander Turenko via Tarantool-patches
  0 siblings, 0 replies; 4+ messages in thread
From: Alexander Turenko via Tarantool-patches @ 2021-03-11 12:33 UTC (permalink / raw)
  To: Sergey Kaplun; +Cc: tarantool-patches

Pushed to test-run's master.

Updated the test-run submodule in tarantool in 2.8.0-112-gffab1320f,
2.7.1-101-gbcd3fd60e, 2.6.2-98-g80a0dc499, 1.10.9-54-ge0f0f85bf.

WBR, Alexander Turenko.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-11 12:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10  9:39 [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module Sergey Kaplun via Tarantool-patches
2021-03-11  8:05 ` Alexander Turenko via Tarantool-patches
2021-03-11  8:42   ` Sergey Kaplun via Tarantool-patches
2021-03-11 12:33     ` Alexander Turenko via Tarantool-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox