Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module
Date: Thu, 11 Mar 2021 11:42:40 +0300	[thread overview]
Message-ID: <20210311084240.GK6842@root> (raw)
In-Reply-To: <20210311080506.dhv6xxvqt3ohvuif@tkn_work_nb>

Hi!

On 11.03.21, Alexander Turenko wrote:
> On Wed, Mar 10, 2021 at 12:39:05PM +0300, Sergey Kaplun wrote:
> > LuaJIT built-in misc was introduced via
> > tarantool/tarantool@e5039742eba89936bf2f8c5aebc8f21c810710d5
> > (luajit: bump new version) in Tarantool and via
> > tarantool/luajit@5a61e1ab54b5c66bfebd836db1ac47996611e065
> > (misc: add C and Lua API for platform metrics) in LuaJIT fork.
> > 
> > Follows up tarantool/tarantool#5187
> > ---
> > Branch: https://github.com/tarantool/test-run/tree/skaplun/gh-noticket-add-misc-bultin-in-pretest-clean
> > 
> >  pretest_clean.lua | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/pretest_clean.lua b/pretest_clean.lua
> > index 9b5ac9d..8ea07e0 100644
> > --- a/pretest_clean.lua
> > +++ b/pretest_clean.lua
> > @@ -264,6 +264,7 @@ local function clean()
> >          json = true,
> >          log = true,
> >          math = true,
> > +        misc = true,
> >          msgpack = true,
> >          msgpackffi = true,
> >          ['net.box'] = true,
> 
> The module is loaded by default, so I would add it to 'allowed_globals'
> too.

Thanks, my bad! Fixed and force-pushed to the branch. See the iterative
patch below:

===================================================================
diff --git a/pretest_clean.lua b/pretest_clean.lua
index 8ea07e0..446ecf2 100644
--- a/pretest_clean.lua
+++ b/pretest_clean.lua
@@ -155,6 +155,7 @@ local function clean()
         io = true,
         jit = true,
         math = true,
+        misc = true,
         os = true,
         package = true,
         string = true,
===================================================================

-- 
Best regards,
Sergey Kaplun

  reply	other threads:[~2021-03-11  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  9:39 Sergey Kaplun via Tarantool-patches
2021-03-11  8:05 ` Alexander Turenko via Tarantool-patches
2021-03-11  8:42   ` Sergey Kaplun via Tarantool-patches [this message]
2021-03-11 12:33     ` Alexander Turenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311084240.GK6842@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH test-run] pretest_clean: add misc LuaJIT built-in module' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox