From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites Date: Wed, 10 Mar 2021 19:25:07 +0300 [thread overview] Message-ID: <20210310162507.GT9042@tarantool.org> (raw) In-Reply-To: <20210309235917.GO9042@tarantool.org> Sergey, I've checked the mentioned patchset into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master. On 10.03.21, Igor Munkin wrote: > Sergey, > > I've precisely reviewed patches 04-09 and they look good. I've polished > a bit[1] the series, so it can be applied to the trunk out of the order. > CI[2] is green. > > BTW, I would like to leave some major points related to my review. > > 1. The suite has been taken intact. To check this I used the following > recipe: > | $ pwd > | /LuaJIT-test-cleanup/test > | $ git remote -v > | origin https://github.com/LuaJIT/LuaJIT-test-cleanup.git (fetch) > | origin https://github.com/LuaJIT/LuaJIT-test-cleanup.git (push) > | $ git lo -1 > | 014708b (HEAD -> master, origin/master, origin/HEAD) Add test for BC_VARG slot revival > | $ find . -type f | sort | xargs md5sum > ~/vanilla > | <...> > | $ pwd > | /tarantool-luajit/test/LuaJIT-test > | $ git remote -v > | origin git@github.com:tarantool/luajit (fetch) > | origin git@github.com:tarantool/luajit (push) > | $ git lo -1 > | cc0967c (HEAD) test: add LuaJIT-test-cleanup test suite > | $ find . -type f | sort | xargs md5sum > ~/tarantool > | $ diff ~/vanilla ~/tarantool > | > 91cb30f369b83d7626a8ae852781ebb5 ./CMakeLists.txt > > 2. I've introduced a new CMake option: LUAJIT_TEST_INIT. You can read > the description here[3]. It allows to enclose the partial LUA_INIT > emulation, implemented via '-e dofile[[${LUAJIT_TEST_INIT}]]' and > obliges user to set the name of the Lua script to be run prior to the > testing suite[4]. By default it does nothing by reading from /dev/null. > > 3. Since CLI flags can be used for LuaJIT testing now, <utils.selfrun> > need to be adjusted[5] to respect the passed flags in child process. > > This part LGTM, so if nobody is against the version I've checked to the > branch[1], then I apply it to the trunk after your and Sergos approval. > > On 04.03.21, Sergey Kaplun wrote: <snipped> > > [1]: https://github.com/tarantool/luajit/tree/imun/tarantool-test > [2]: https://github.com/tarantool/tarantool/tree/imun/luajit-test > [3]: https://github.com/tarantool/luajit/commit/9712cc9#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR291-R307 > [4]: https://github.com/tarantool/tarantool/commit/03b04a7 > [5]: https://github.com/tarantool/luajit/commit/72f87b2 > > -- > Best regards, > IM -- Best regards, IM
prev parent reply other threads:[~2021-03-10 16:25 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-04 10:23 Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 01/15] test: add PUC-Rio Lua 5.1 test suite Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 02/15] test: adapt PUC-Rio Lua 5.1 test suite for LuaJIT Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 03/15] test: adapt Lua 5.1 test suite for Tarantool Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 04/15] test: add LuaJIT-test-cleanup test suite Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 05/15] test: change tests to match de5568e Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 06/15] test: change tests to match c198167 Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 07/15] test: change tests to match 5a61e1a Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 08/15] test: change LuaJIT suite tests to match b4e6bf0 Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 09/15] test: adjust LuaJIT test suite for Tarantool Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 10/15] test: add lua-Harness test suite Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 11/15] test: adjust lua-Harness test suite for Tarantool Sergey Kaplun via Tarantool-patches 2021-03-04 10:23 ` [Tarantool-patches] [WIP luajit 12/15] test: disable 305-utf8 of lua-Harness suite Sergey Kaplun via Tarantool-patches 2021-03-04 10:24 ` [Tarantool-patches] [WIP luajit 13/15] test: disable 241-standalone " Sergey Kaplun via Tarantool-patches 2021-03-04 10:24 ` [Tarantool-patches] [WIP luajit 14/15] test: disable 411-luajit " Sergey Kaplun via Tarantool-patches 2021-03-04 10:24 ` [Tarantool-patches] [WIP luajit 15/15] test: skip test for getenv in 309-os.t Sergey Kaplun via Tarantool-patches 2021-03-04 16:24 ` [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites Sergey Ostanevich via Tarantool-patches 2021-03-04 19:58 ` Sergey Kaplun via Tarantool-patches 2021-03-05 10:48 ` Sergey Ostanevich via Tarantool-patches 2021-03-16 11:21 ` Igor Munkin via Tarantool-patches 2021-03-09 23:59 ` Igor Munkin via Tarantool-patches 2021-03-10 8:09 ` Sergey Kaplun via Tarantool-patches 2021-03-10 10:39 ` Igor Munkin via Tarantool-patches 2021-03-10 9:46 ` Sergey Ostanevich via Tarantool-patches 2021-03-10 10:43 ` Igor Munkin via Tarantool-patches 2021-03-10 16:25 ` Igor Munkin via Tarantool-patches [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210310162507.GT9042@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox