Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

I've checked the mentioned patchset into all long-term branches in
tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master.

On 10.03.21, Igor Munkin wrote:
> Sergey,
> 
> I've precisely reviewed patches 04-09 and they look good. I've polished
> a bit[1] the series, so it can be applied to the trunk out of the order.
> CI[2] is green.
> 
> BTW, I would like to leave some major points related to my review.
> 
> 1. The suite has been taken intact. To check this I used the following
> recipe:
> | $ pwd
> | /LuaJIT-test-cleanup/test
> | $ git remote -v
> | origin  https://github.com/LuaJIT/LuaJIT-test-cleanup.git (fetch)
> | origin  https://github.com/LuaJIT/LuaJIT-test-cleanup.git (push)
> | $ git lo -1
> | 014708b (HEAD -> master, origin/master, origin/HEAD) Add test for BC_VARG slot revival
> | $ find . -type f | sort | xargs md5sum > ~/vanilla
> | <...>
> | $ pwd
> | /tarantool-luajit/test/LuaJIT-test
> | $ git remote -v
> | origin  git@github.com:tarantool/luajit (fetch)
> | origin  git@github.com:tarantool/luajit (push)
> | $ git lo -1
> | cc0967c (HEAD) test: add LuaJIT-test-cleanup test suite
> | $ find . -type f | sort | xargs md5sum > ~/tarantool
> | $ diff ~/vanilla ~/tarantool
> | > 91cb30f369b83d7626a8ae852781ebb5  ./CMakeLists.txt
> 
> 2. I've introduced a new CMake option: LUAJIT_TEST_INIT. You can read
> the description here[3]. It allows to enclose the partial LUA_INIT
> emulation, implemented via '-e dofile[[${LUAJIT_TEST_INIT}]]' and
> obliges user to set the name of the Lua script to be run prior to the
> testing suite[4]. By default it does nothing by reading from /dev/null.
> 
> 3. Since CLI flags can be used for LuaJIT testing now, <utils.selfrun>
> need to be adjusted[5] to respect the passed flags in child process.
> 
> This part LGTM, so if nobody is against the version I've checked to the
> branch[1], then I apply it to the trunk after your and Sergos approval.
> 
> On 04.03.21, Sergey Kaplun wrote:

<snipped>

> 
> [1]: https://github.com/tarantool/luajit/tree/imun/tarantool-test
> [2]: https://github.com/tarantool/tarantool/tree/imun/luajit-test
> [3]: https://github.com/tarantool/luajit/commit/9712cc9#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR291-R307
> [4]: https://github.com/tarantool/tarantool/commit/03b04a7
> [5]: https://github.com/tarantool/luajit/commit/72f87b2
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
IM