From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B46656EC59; Wed, 10 Mar 2021 19:25:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B46656EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615393516; bh=cg5cJp/tAOmvKaVXo/+qjyDIXu4cY5RA2UAhRsjBwCI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BJsYSQytGpZy1O07+pVZxmkyQ6xaZ2kF2FihVNCENCL1jzmksWCUd+vK2x/SVp2DI GrJwxVUlgGRWKawexOCSBn3oZM1hxIgu1rQWb3tCRjcn1GeZtAwOq5G8p8s0VwFAee WXd3h6TfORRBAEGSwj5QNOQarbcqtBd0faVSJxrw= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 653716EC59 for ; Wed, 10 Mar 2021 19:25:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 653716EC59 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lK1e6-00050T-77; Wed, 10 Mar 2021 19:25:14 +0300 Date: Wed, 10 Mar 2021 19:25:07 +0300 To: Sergey Kaplun Message-ID: <20210310162507.GT9042@tarantool.org> References: <20210309235917.GO9042@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309235917.GO9042@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B9676070C5F64E418DB309FBA590CF44700894C459B0CD1B96A8E4D424187559AAE5825134FB0C14D3F63A53D7F9ED32115CD2B5BB6EB5A8F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75B37E0A1C175363BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459430292EC88638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C11F5982A89E0728CD175BD17AB7CE775A73941A4A9F17A79A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23DF004C9065253843057739F23D657EF2B13377AFFFEAFD26923F8577A6DFFEA7CA35FE21102777C0993EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B6F82A78844E5C6993089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A558715D7E9A33020420EE41346FF4C4BF993EDF07E19C09B5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F6CC1FD33669633613C86A65EA2165919E9A4927C5EDC05E33765C5F6939044570F589386D2448AD1D7E09C32AA3244CA0D7AB24B5C1EE281CDAE72FE2485EDDF94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojsR8tyFmO15MwH8Wzzz2V0w== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638221BBCFDF36798067B2E02F4E0D9D21412A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, I've checked the mentioned patchset into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master. On 10.03.21, Igor Munkin wrote: > Sergey, > > I've precisely reviewed patches 04-09 and they look good. I've polished > a bit[1] the series, so it can be applied to the trunk out of the order. > CI[2] is green. > > BTW, I would like to leave some major points related to my review. > > 1. The suite has been taken intact. To check this I used the following > recipe: > | $ pwd > | /LuaJIT-test-cleanup/test > | $ git remote -v > | origin https://github.com/LuaJIT/LuaJIT-test-cleanup.git (fetch) > | origin https://github.com/LuaJIT/LuaJIT-test-cleanup.git (push) > | $ git lo -1 > | 014708b (HEAD -> master, origin/master, origin/HEAD) Add test for BC_VARG slot revival > | $ find . -type f | sort | xargs md5sum > ~/vanilla > | <...> > | $ pwd > | /tarantool-luajit/test/LuaJIT-test > | $ git remote -v > | origin git@github.com:tarantool/luajit (fetch) > | origin git@github.com:tarantool/luajit (push) > | $ git lo -1 > | cc0967c (HEAD) test: add LuaJIT-test-cleanup test suite > | $ find . -type f | sort | xargs md5sum > ~/tarantool > | $ diff ~/vanilla ~/tarantool > | > 91cb30f369b83d7626a8ae852781ebb5 ./CMakeLists.txt > > 2. I've introduced a new CMake option: LUAJIT_TEST_INIT. You can read > the description here[3]. It allows to enclose the partial LUA_INIT > emulation, implemented via '-e dofile[[${LUAJIT_TEST_INIT}]]' and > obliges user to set the name of the Lua script to be run prior to the > testing suite[4]. By default it does nothing by reading from /dev/null. > > 3. Since CLI flags can be used for LuaJIT testing now, > need to be adjusted[5] to respect the passed flags in child process. > > This part LGTM, so if nobody is against the version I've checked to the > branch[1], then I apply it to the trunk after your and Sergos approval. > > On 04.03.21, Sergey Kaplun wrote: > > [1]: https://github.com/tarantool/luajit/tree/imun/tarantool-test > [2]: https://github.com/tarantool/tarantool/tree/imun/luajit-test > [3]: https://github.com/tarantool/luajit/commit/9712cc9#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR291-R307 > [4]: https://github.com/tarantool/tarantool/commit/03b04a7 > [5]: https://github.com/tarantool/luajit/commit/72f87b2 > > -- > Best regards, > IM -- Best regards, IM