From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: Alexander Turenko <alexander.turenko@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths
Date: Wed, 10 Mar 2021 03:14:30 +0300 [thread overview]
Message-ID: <20210310001430.GQ9042@tarantool.org> (raw)
In-Reply-To: <20210308192635.GG6842@root>
Sergey,
Thanks for your review!
On 08.03.21, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
>
> LGTM!
Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
>
> `${LUACHECK_SOURCE_DIR}` and `${LUACHECK_BINARY_DIR}` look more
> consistent for me (according to other variables naming), but it's up to
> you.
> Feel free to ignore.
Fixed, squashed, force-pushed to the branch.
>
> On 06.03.21, Igor Munkin wrote:
> > Unfortunately, luacheck doesn't handle the working directory or one used
> > in options if it is not a real path. As a result of this patch both
> > PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used
> > within luacheck target custom command.
> >
> > The issue has been already fixed in Tarantool repo after applying
>
> Nit: "same issue" or "similar issue"
> Feel free to ignore.
The definite article does its job here.
Ignoring.
>
> > af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck
> > invocation in different cases'), and this patch is necessary, since
> > <LuaJIT-luacheck> is the dependency for Tarantool <luacheck> target.
> >
> > Relates to mpeterv/luacheck#208
> >
> > Reported-by: Alexander Turenko <alexander.turenko@tarantool.org>
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
>
> <snipped>
>
> >
>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
next prev parent reply other threads:[~2021-03-10 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 23:20 Igor Munkin via Tarantool-patches
2021-03-08 4:27 ` Alexander Turenko via Tarantool-patches
2021-03-10 0:14 ` Igor Munkin via Tarantool-patches
2021-03-08 19:26 ` Sergey Kaplun via Tarantool-patches
2021-03-10 0:14 ` Igor Munkin via Tarantool-patches [this message]
2021-03-10 16:25 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310001430.GQ9042@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox