From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths
Date: Wed, 10 Mar 2021 03:14:16 +0300 [thread overview]
Message-ID: <20210310001416.GP9042@tarantool.org> (raw)
In-Reply-To: <20210308042714.kqq6igequelxk642@tkn_work_nb>
Sasha,
Thanks for your review!
On 08.03.21, Alexander Turenko wrote:
> LGTM.
Added your tag:
| Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>
>
> Just curious, why you don't need exclusion of a build directory for the
> case, when it is inside the source directory?
As we discussed before, there is a single Lua file within build
directory: jit/vmdef.lua. Hence, it's enough to exclude only this file.
>
> WBR, Alexander Turenko.
>
> > Branch: https://github.com/tarantool/luajit/tree/imun/luacheck-realpath
> > CI is green on this branch (see the tick near the HEAD commit):
> > https://github.com/tarantool/tarantool/tree/imun/fix-luacheck-invocation
--
Best regards,
IM
next prev parent reply other threads:[~2021-03-10 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 23:20 Igor Munkin via Tarantool-patches
2021-03-08 4:27 ` Alexander Turenko via Tarantool-patches
2021-03-10 0:14 ` Igor Munkin via Tarantool-patches [this message]
2021-03-08 19:26 ` Sergey Kaplun via Tarantool-patches
2021-03-10 0:14 ` Igor Munkin via Tarantool-patches
2021-03-10 16:25 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310001416.GP9042@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=imun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox