Re: [Tarantool-patches] [PATCH v2] tools: fix luacheck invocation in different cases

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sasha,

On 05.03.21, Alexander Turenko wrote:

<snipped>

> 
> > > BTW, while looking into the problem with Igor, we found that luajit's
> > > luacheck rule fails on source / build paths with symlinks components.
> > > The solution is to use real paths everywhere.
> > 
> > I take this upon myself.
> 
> Thank you!

Here is the patch[1].

> 
> I should mention that there is the problem with the LuaJIT CMake rule in
> the commit message.
> 
>  | -Now `make luacheck` gracefully handles different cases: in-source
>  | +Now `make luacheck` gracefully handles different cases[^1]: in-source
>  |  and out-of-source build (within the source tree or outside), current
>  |  working directory as a real path or with symlink components.
>  |
>  |  <...>
>  |
>  | +[^1]: We have the similar problems with LuaJIT's luacheck rule. They
>  | +      will be fixed in a separate patch.
>  |
>  |  [1]: https://github.com/mpeterv/luacheck/issues/208
>  |
>  | +Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
>  | +Reviewed-by: Igor Munkin <imun@tarantool.org>
> 

<snipped>

[1]: https://lists.tarantool.org/tarantool-patches/de1139d94e7501628e69e56d7837fc76cf6b5120.1614986102.git.imun@tarantool.org/T/#u

-- 
Best regards,
IM