Re: [Tarantool-patches] [PATCH v2 06/10] box/vynil: fix say_x format

[Nikita Pettik via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

On 24 Feb 23:43, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> This bug could actually lead to a crash. Because the printer would
> try to read memory by a not passed string pointer.
> 
> Nikita, does it look related to any of the crashes we have in vinyl?

No, it doesn't. Errors at compatin start are rather rare.
 
> On 24.02.2021 16:36, Cyrill Gorcunov wrote:
> > Drop redundant "%s" from format.
> > 
> > Part-of #5846
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > ---
> >  src/box/vy_scheduler.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/box/vy_scheduler.c b/src/box/vy_scheduler.c
> > index b641dd9b8..6f6e9c340 100644
> > --- a/src/box/vy_scheduler.c
> > +++ b/src/box/vy_scheduler.c
> > @@ -1714,7 +1714,7 @@ vy_task_compaction_new(struct vy_scheduler *scheduler, struct vy_worker *worker,
> >  	vy_task_delete(task);
> >  err_task:
> >  	diag_log();
> > -	say_error("%s: could not start compacting range %s: %s",
> > +	say_error("%s: could not start compacting range %s",
> >  		  vy_lsm_name(lsm), vy_range_str(range));
> >  	return -1;
> >  }
> >