From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Nikiforov <void@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 2/2] base64: improve decoder performance
Date: Sat, 20 Feb 2021 15:51:58 +0300 [thread overview]
Message-ID: <20210220125158.r6fgljm5cfrqs2ez@tkn_work_nb> (raw)
In-Reply-To: <ef02e876-3790-f98d-eb6f-95acf6a0a706@tarantool.org>
So we have four topics:
1. Why don't remove the unused (status storing) code?
2. Internal API changes that we definitely should do: error reporting
for too short output buffer.
3. Internal API changes that are subject to discussion: input
validation.
4. Optimizations.
I highly want to define precisely the internal API first (have agreement
on 1, 2, 3 at least, but better have it implemented) and only then
discuss optimizations. Otherwise any proposed optimization may become
impossible (or just unneeded).
Sorry, but I'll postpone the discussion regarding optimizations because
of this.
WBR, Alexander Turenko.
next prev parent reply other threads:[~2021-02-20 12:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:44 [Tarantool-patches] [PATCH v6 0/2] base64: Fix decoder, improve its performance Sergey Nikiforov via Tarantool-patches
2021-01-11 9:45 ` [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads) Sergey Nikiforov via Tarantool-patches
2021-01-21 2:16 ` Alexander Turenko via Tarantool-patches
2021-01-26 16:37 ` Sergey Nikiforov via Tarantool-patches
2021-01-26 16:48 ` Sergey Nikiforov via Tarantool-patches
2021-02-20 11:30 ` Alexander Turenko via Tarantool-patches
2021-02-20 12:49 ` Alexander Turenko via Tarantool-patches
2021-02-25 8:25 ` Sergey Nikiforov via Tarantool-patches
2021-02-27 18:47 ` Alexander Turenko via Tarantool-patches
2021-01-11 9:45 ` [Tarantool-patches] [PATCH v6 2/2] base64: improve decoder performance Sergey Nikiforov via Tarantool-patches
2021-01-21 15:31 ` Alexander Turenko via Tarantool-patches
2021-01-26 16:37 ` Sergey Nikiforov via Tarantool-patches
2021-02-20 12:51 ` Alexander Turenko via Tarantool-patches [this message]
2021-01-12 19:39 ` [Tarantool-patches] [PATCH v6 0/2] base64: Fix decoder, improve its performance Alexander Turenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210220125158.r6fgljm5cfrqs2ez@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=void@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 2/2] base64: improve decoder performance' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox