Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for your review!

On 15.02.21, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> 
> LGTM, except a few nits below.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 
> On 04.02.21, Igor Munkin wrote:
> > This patch adds LuaJIT tests to every CI job type except the one for
> > static build testing routine on OSX: there is no way to run LuaJIT tests
> > for out of source build on OSX due to SIP[1].
> > 
> > [1]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html
> > 
> > Follows up #4862
> 
> Nit: looks like 'Closes' not 'Follows up'.
> Feel free to ignore.

No, the issue is closed via the previous commit. There is not a word
about CI in the issue, so this commit simply follows up the closing one.

Ignoring.

> 
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> >  .travis.mk | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> 
> Nit: There is one general comment for the whole patch:
> In my opinion, it is better to run `make LuaJIT-tests` **before**
> Tarantool test suite. If LuaJIT is broken failed Tarantool tests
> information is useless (Is it LuaJIT? Always has been.).
> Feel free to ignore.

I assume the following: there is no flaky tests in LuaJIT (at least now)
but there are many in Tarantool. If we place LuaJIT-related tests before
Tarantool tests, then we need to rerun the former if the latter fail.
But when Tarantool tests fully succeed (even with no test-run internal
issues), LuaJIT tests are unlikely to fail. This makes sense when LuaJIT
tests will grow in a nearest future.

Ignoring for now but let's return to the question if it is necessary.

> 

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM