From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation
Date: Sat, 20 Feb 2021 00:17:35 +0300 [thread overview]
Message-ID: <20210219211735.GQ5448@tarantool.org> (raw)
In-Reply-To: <20210215131209.GH9361@root>
Sergey,
Thanks for your review!
On 15.02.21, Sergey Kaplun wrote:
> Hi, Igor!
>
> Thanks for the patch!
>
> LGTM, except one nitpick below.
Fixed the nit below and added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
>
<snipped>
> --
> Best regards,
> Sergey Kaplun
--
Best regards,
IM
next prev parent reply other threads:[~2021-02-19 21:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 23:22 [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Igor Munkin via Tarantool-patches
2021-02-03 23:22 ` [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation Igor Munkin via Tarantool-patches
2021-02-15 13:12 ` Sergey Kaplun via Tarantool-patches
2021-02-19 21:17 ` Igor Munkin via Tarantool-patches [this message]
2021-02-03 23:22 ` [Tarantool-patches] [PATCH 2/3] build: adjust LuaJIT build system Igor Munkin via Tarantool-patches
2021-02-15 16:13 ` Sergey Kaplun via Tarantool-patches
2021-02-19 23:10 ` Igor Munkin via Tarantool-patches
2021-02-20 7:42 ` Timur Safin via Tarantool-patches
2021-02-03 23:22 ` [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI Igor Munkin via Tarantool-patches
2021-02-15 16:29 ` Sergey Kaplun via Tarantool-patches
2021-02-19 21:29 ` Igor Munkin via Tarantool-patches
[not found] ` <0b6601d7075c$64329060$2c97b120$@tarantool.org>
2021-02-20 10:18 ` Igor Munkin via Tarantool-patches
2021-02-24 7:16 ` Timur Safin via Tarantool-patches
2021-02-25 22:08 ` Igor Munkin via Tarantool-patches
2021-02-26 19:04 ` Timur Safin via Tarantool-patches
2021-02-26 19:09 ` [Tarantool-patches] [PATCH 0/3] Adjust LuaJIT build system Timur Safin via Tarantool-patches
2021-02-26 21:06 ` Igor Munkin via Tarantool-patches
2021-02-27 13:56 ` Sergey Kaplun via Tarantool-patches
2021-02-28 22:05 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219211735.GQ5448@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox