Re: [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Igor!

Thanks for the patch!

LGTM, except one nitpick below.

On 04.02.21, Igor Munkin wrote:
> If Lua source path given to <lua_source> function is relative, the

Typo? s/Lua source path/the Lua source path/
Feel free to ignore.

> output file is generated in the binary directory. At the same time if
> the given path to be compiled to *.lua.c is absolute, the output
> file is generated in source directory instead of the binary one. This
> patch fixes the latter case providing the valid behaviour for out of

Typo: s/case providing/case, providing/

> source build type.
> 
> Needed for #4862
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>  cmake/utils.cmake | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/cmake/utils.cmake b/cmake/utils.cmake
> index eaec821b3..6d6960468 100644
> --- a/cmake/utils.cmake
> +++ b/cmake/utils.cmake
> @@ -40,9 +40,11 @@ endmacro(set_source_files_compile_flags)

<snipped>

> -- 
> 2.25.0
> 

-- 
Best regards,
Sergey Kaplun