Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Timur Safin <tsafin@tarantool.org>
Cc: s.ostanevich@corp.mail.ru, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking
Date: Sat, 13 Feb 2021 18:13:54 +0300	[thread overview]
Message-ID: <20210213151354.GA110441@tarantool.org> (raw)
In-Reply-To: <047b01d6fec6$fbbb8ac0$f332a040$@tarantool.org>

On Tue, Feb 09, 2021 at 12:36:03PM +0300, Timur Safin wrote:
Hi! Thank you for the review. I squashed almost all patches in one.
Also, I replaced static_alloc() by region_alloc().

I will send it as a new patch-set.


> Thanks for this refactoring attempt, but could you (please, please) 
> make it (somehow magically) easier to review? I mean the part where
> we extract something from here, wrap I as a function, and replace
> with that function call ideally would be to put to the same patch -
> for better observability. So we make it more visible that functionality
> remains intact?
> I know that is tricky in git, but possible after some massaging. (May 
> Be simply squash it to the single patch as a first approach?)
> 
> I've no much complains yet about particular cases - but there is 
> some objection about newly introduced static_alloc, please see in 
> other message.
> 
> Regards,
> Timur
> 
> : From: imeevma@tarantool.org <imeevma@tarantool.org>
> : Subject: [PATCH v1 00/10] Encapsulate MEM type changing and checking
> : 
> : This patch-set encapsulates type changing and checking for MEM. This is done
> : to
> : make easier for us to introduce new rules for implicit and explicit type
> : casting
> : and new types in SQL.
> : 
> : https://github.com/tarantool/tarantool/issues/4470
> : https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-encapsule-type-
> : setting-v3
> : 
> : 
> : Mergen Imeev (10):
> :   sql: introduce mem_set_*() functions
> :   sql: Initialize MEM in sqlVdbeAllocUnpackedRecord()
> :   sql: introduce mem_is_*() functions
> :   sql: introduce mem_convert_to_binary()
> :   sql: refactor vdbesort.c
> :   sql: refactor sql/func.c
> :   sql: refactor vdbetrace.c
> :   sql: refactor vdbeapi.c
> :   sql: refactor vdbeaux.c
> :   sql: refactor vdbe.c
> : 
> :  src/box/sql/func.c      |   2 +-
> :  src/box/sql/vdbe.c      | 453 ++++++++++++++++++----------------------
> :  src/box/sql/vdbeInt.h   | 204 ++++++++++++++++++
> :  src/box/sql/vdbeapi.c   |  53 ++---
> :  src/box/sql/vdbeaux.c   | 268 +++++++++++-------------
> :  src/box/sql/vdbemem.c   | 116 ++++++++++
> :  src/box/sql/vdbesort.c  |   9 +-
> :  src/box/sql/vdbetrace.c |  12 +-
> :  8 files changed, 674 insertions(+), 443 deletions(-)
> : 
> : --
> : 2.25.1
> 
> 

      reply	other threads:[~2021-02-13 15:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01  8:14 Mergen Imeev via Tarantool-patches
2021-02-01  8:14 ` [Tarantool-patches] [PATCH v1 01/10] sql: introduce mem_set_*() functions Mergen Imeev via Tarantool-patches
2021-02-01  8:14 ` [Tarantool-patches] [PATCH v1 02/10] sql: Initialize MEM in sqlVdbeAllocUnpackedRecord() Mergen Imeev via Tarantool-patches
2021-02-01  8:14 ` [Tarantool-patches] [PATCH v1 03/10] sql: introduce mem_is_*() functions Mergen Imeev via Tarantool-patches
2021-02-01  8:14 ` [Tarantool-patches] [PATCH v1 04/10] sql: introduce mem_convert_to_binary() Mergen Imeev via Tarantool-patches
2021-02-01  8:14 ` [Tarantool-patches] [PATCH v1 05/10] sql: refactor vdbesort.c Mergen Imeev via Tarantool-patches
2021-02-01  8:15 ` [Tarantool-patches] [PATCH v1 06/10] sql: refactor sql/func.c Mergen Imeev via Tarantool-patches
2021-02-01  8:15 ` [Tarantool-patches] [PATCH v1 07/10] sql: refactor vdbetrace.c Mergen Imeev via Tarantool-patches
2021-02-01  8:15 ` [Tarantool-patches] [PATCH v1 08/10] sql: refactor vdbeapi.c Mergen Imeev via Tarantool-patches
2021-02-01  8:15 ` [Tarantool-patches] [PATCH v1 09/10] sql: refactor vdbeaux.c Mergen Imeev via Tarantool-patches
2021-02-09  9:51   ` [Tarantool-patches] FW: " Timur Safin via Tarantool-patches
2021-02-13 15:33     ` Mergen Imeev via Tarantool-patches
2021-02-28 17:35     ` Vladislav Shpilevoy via Tarantool-patches
2021-02-01  8:15 ` [Tarantool-patches] [PATCH v1 10/10] sql: refactor vdbe.c Mergen Imeev via Tarantool-patches
     [not found]   ` <047f01d6fec7$b5a90bb0$20fb2310$@tarantool.org>
2021-02-13 15:26     ` Mergen Imeev via Tarantool-patches
2021-02-09  9:36 ` [Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking Timur Safin via Tarantool-patches
2021-02-13 15:13   ` Mergen Imeev via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210213151354.GA110441@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=s.ostanevich@corp.mail.ru \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox