From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5F4716EC6F; Sat, 13 Feb 2021 18:14:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5F4716EC6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613229241; bh=pvpiNSL2U1tj1orrOUZXrySQllLddGwSDRgethyu5wY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OwdDyoIZPYkPebxfwhtrmIoI1RGeiNfCzWG/kWMDn804pcwO4LfUc5ZEl5xb6yw1l +hyPU3yya3t5uxbNvBojctszRVGe+YGYdGUz0oApdsA5oG33TirYEquIkNxu0xw9Y8 9wfpdGedr6Ztn3AmQkr4UXB4sbKElXZFtBjIeVX8= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ABF816EC6F for ; Sat, 13 Feb 2021 18:13:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ABF816EC6F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lAwcN-0005fY-ID; Sat, 13 Feb 2021 18:13:55 +0300 Date: Sat, 13 Feb 2021 18:13:54 +0300 To: Timur Safin Cc: s.ostanevich@corp.mail.ru, tarantool-patches@dev.tarantool.org Message-ID: <20210213151354.GA110441@tarantool.org> References: <047b01d6fec6$fbbb8ac0$f332a040$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <047b01d6fec6$fbbb8ac0$f332a040$@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD981647AC6901E234B76E96810B840B3DA78548B6B9C68F4E9182A05F5380850408B5E6A7947BC3218D93549529AF764FEDFD2B27EC0A3A8675B1598DF0DFAA475 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77BF46084C0059042EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC97BDA337793EA445EC9B8CA68EE7CE975DEC8732BB42BF4A389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC696E4123C2B4120575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E7351CE60B8040019C36C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0FECB2555BB02FD5A93B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A542495663E4B37BA907298DC892678E68281F5D52F98D3E05D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA13E2DDB90678623DAC3EC77D9A1284CDEE20164F2636B281384B924125479DC3006198176700271D7E09C32AA3244C2747D3F5BE268CAD2EF205174B6998C5725D5B54B2FE4575FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+JvDbeHF34xJOtm3qNOdAA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638223AF46E6440A017836D451AA12D3ECD4283D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 00/10] Encapsulate MEM type changing and checking X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Feb 09, 2021 at 12:36:03PM +0300, Timur Safin wrote: Hi! Thank you for the review. I squashed almost all patches in one. Also, I replaced static_alloc() by region_alloc(). I will send it as a new patch-set. > Thanks for this refactoring attempt, but could you (please, please) > make it (somehow magically) easier to review? I mean the part where > we extract something from here, wrap I as a function, and replace > with that function call ideally would be to put to the same patch - > for better observability. So we make it more visible that functionality > remains intact? > I know that is tricky in git, but possible after some massaging. (May > Be simply squash it to the single patch as a first approach?) > > I've no much complains yet about particular cases - but there is > some objection about newly introduced static_alloc, please see in > other message. > > Regards, > Timur > > : From: imeevma@tarantool.org > : Subject: [PATCH v1 00/10] Encapsulate MEM type changing and checking > : > : This patch-set encapsulates type changing and checking for MEM. This is done > : to > : make easier for us to introduce new rules for implicit and explicit type > : casting > : and new types in SQL. > : > : https://github.com/tarantool/tarantool/issues/4470 > : https://github.com/tarantool/tarantool/tree/imeevma/gh-4470-encapsule-type- > : setting-v3 > : > : > : Mergen Imeev (10): > : sql: introduce mem_set_*() functions > : sql: Initialize MEM in sqlVdbeAllocUnpackedRecord() > : sql: introduce mem_is_*() functions > : sql: introduce mem_convert_to_binary() > : sql: refactor vdbesort.c > : sql: refactor sql/func.c > : sql: refactor vdbetrace.c > : sql: refactor vdbeapi.c > : sql: refactor vdbeaux.c > : sql: refactor vdbe.c > : > : src/box/sql/func.c | 2 +- > : src/box/sql/vdbe.c | 453 ++++++++++++++++++---------------------- > : src/box/sql/vdbeInt.h | 204 ++++++++++++++++++ > : src/box/sql/vdbeapi.c | 53 ++--- > : src/box/sql/vdbeaux.c | 268 +++++++++++------------- > : src/box/sql/vdbemem.c | 116 ++++++++++ > : src/box/sql/vdbesort.c | 9 +- > : src/box/sql/vdbetrace.c | 12 +- > : 8 files changed, 674 insertions(+), 443 deletions(-) > : > : -- > : 2.25.1 > >