Tarantool development patches archive
 help / color / mirror / Atom feed
From: Cyrill Gorcunov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] txn: convert flags to explicit bitfield
Date: Fri, 5 Feb 2021 11:22:07 +0300	[thread overview]
Message-ID: <20210205082207.GI2172@grain> (raw)
In-Reply-To: <358c2eb8-0866-95f5-93a8-316eed6c1146@tarantool.org>

On Fri, Feb 05, 2021 at 10:53:32AM +0300, Serge Petrenko wrote:
> > Yes, but this won't get exact match for txn_has_flag, which tests
> > for a single bit now. Surely I can setup
> Ok, I see. Why not make txn_has_flag check for entire flag then?
> > 
> > 
> > if you and Vlad agrees.
> Let's wait for what Vlad has to say

You know, I tried various ways. None of them satisfied me :/
I propose to close this issue and leave everything as is,
at least currently code as a way more readable I think.

      reply	other threads:[~2021-02-05  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 11:19 Cyrill Gorcunov via Tarantool-patches
2021-02-04 14:01 ` Serge Petrenko via Tarantool-patches
2021-02-04 14:31   ` Cyrill Gorcunov via Tarantool-patches
2021-02-05  7:53     ` Serge Petrenko via Tarantool-patches
2021-02-05  8:22       ` Cyrill Gorcunov via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205082207.GI2172@grain \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v3] txn: convert flags to explicit bitfield' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox