From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 61B836C7D3; Fri, 5 Feb 2021 11:22:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61B836C7D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612513332; bh=fv91ajo6PxF4APyUY+JCyDQYPehXRQID35rQDn9bjEo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mhcz9aLItB80aPGfodjZ77thbsm+pnaBGvYxnGwPIhX3jTvIf8h2ZlPDcQ6jqed2J 3m4kikJgtXLfbBr3gCr1g0ORSKUnUBhMCOzdKjDg3kaPlR30OnluGtTpz5znmokeIM ElSlGIbUvsB1G5rJFY+m9C4qPAs+sR6xTYXGgApk= Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DDA1F6C7D3 for ; Fri, 5 Feb 2021 11:22:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DDA1F6C7D3 Received: by mail-lj1-f181.google.com with SMTP id m22so6742865ljj.4 for ; Fri, 05 Feb 2021 00:22:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vvUC+46JT7XafBCxk4bKaSvUqO4PYNYR2ZuPCeKvTws=; b=uUXPKq+tvRG5EUxnxc5118CHiHF35uGIbM3ZVw2WN6v3WnTLyUzOljEY+dg3R3qLwM Ei722cG7JRZhg7VQj6SsdeWdKjIozKXUihsAdhZVWiOKNH2uzAsLtAUvtkPNwKEOA9Z4 uWzu+gCAEEGi57tx2TT12hC2zysEPMiPqcY7f6W1TVkyklUfcktJ2+uAR1wFYSodvYIX AG+NKF/63kUTiy7VkV9SKpAqGwIAIp9XD+C0IIXLbv020n4GJrbfG6L7iNUKH74hMG9V gI9NOHuSMU9zHQpXrM5Ka7ffpBPNUozkIRKJT5c+XbGnev0Q0MVJTbw/PDbPoH1hPait Vr/g== X-Gm-Message-State: AOAM531ZJNayTJlwXM31aJ/Yt5UGE5+IVu6W9BNKNZwilYrt1rxHb8ey Io0dkeQLXIe5mVWp9fUUQHdhPv+C76I= X-Google-Smtp-Source: ABdhPJxx/nfWMMme8WYaSgTW+Y9/l2TbyezXr5N/NeJz0iCj8F3VLVvYnNH7ezkEzE5G1zh1gdN3gA== X-Received: by 2002:a2e:7e03:: with SMTP id z3mr2047659ljc.204.1612513329790; Fri, 05 Feb 2021 00:22:09 -0800 (PST) Received: from grain.localdomain ([5.18.103.226]) by smtp.gmail.com with ESMTPSA id r72sm900582lff.214.2021.02.05.00.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 00:22:08 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 7C6CA560088; Fri, 5 Feb 2021 11:22:07 +0300 (MSK) Date: Fri, 5 Feb 2021 11:22:07 +0300 To: Serge Petrenko Message-ID: <20210205082207.GI2172@grain> References: <20210204111912.496547-1-gorcunov@gmail.com> <20210204143157.GG2172@grain> <358c2eb8-0866-95f5-93a8-316eed6c1146@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <358c2eb8-0866-95f5-93a8-316eed6c1146@tarantool.org> User-Agent: Mutt/1.14.6 (2020-07-11) Subject: Re: [Tarantool-patches] [PATCH v3] txn: convert flags to explicit bitfield X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Fri, Feb 05, 2021 at 10:53:32AM +0300, Serge Petrenko wrote: > > Yes, but this won't get exact match for txn_has_flag, which tests > > for a single bit now. Surely I can setup > > Ok, I see. Why not make txn_has_flag check for entire flag then? > > > > > TXN_WAIT_ACK = 0x20 | TXN_WAIT_SYNC > > > > if you and Vlad agrees. > Let's wait for what Vlad has to say You know, I tried various ways. None of them satisfied me :/ I propose to close this issue and leave everything as is, at least currently code as a way more readable I think.