From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] static-build: use hashes of downloaded files
Date: Wed, 27 Jan 2021 21:26:54 +0300 [thread overview]
Message-ID: <20210127182654.3lu6ag352yufsbh5@tkn_work_nb> (raw)
In-Reply-To: <4a34a0310b2529d4d85c534eb05802b0d7076c9b.1611765145.git.sergeyb@tarantool.org>
On Wed, Jan 27, 2021 at 07:37:01PM +0300, sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Using hashes in ExternalProject_Add() [1] allows to avoid extra
> downloads on rebuilds.
>
> 1. https://cmake.org/cmake/help/latest/module/ExternalProject.html
>
> Closes #5761
I don't know this machinery much, but it looks worthful and I don't see
any downsides.
LGTM.
> diff --git a/static-build/CMakeLists.txt b/static-build/CMakeLists.txt
> index 9a2f85052..39cb321d0 100644
> --- a/static-build/CMakeLists.txt
> +++ b/static-build/CMakeLists.txt
> @@ -40,6 +40,7 @@ endif()
> #
> ExternalProject_Add(openssl
> URL https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz
> + URL_MD5 3f486f2f4435ef14b81814dbbc7b48bb
Nit: I would place certain hash values near to the versions block to
don't spread dependent information and descrease probability to forget
to update a checksum together with a version.
next prev parent reply other threads:[~2021-01-27 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 16:37 Sergey Bronnikov via Tarantool-patches
2021-01-27 18:26 ` Alexander Turenko via Tarantool-patches [this message]
2021-01-27 22:19 ` Sergey Bronnikov via Tarantool-patches
2021-01-29 14:42 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127182654.3lu6ag352yufsbh5@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] static-build: use hashes of downloaded files' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox