From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1DE1870310; Wed, 27 Jan 2021 21:28:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1DE1870310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611772121; bh=+2khYd5WD/6dutbgOTmmIMDTSzmTRB9Zo8mgpvf5cL0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QiDl4fiI+w7CcXiUZLYBLT5ebewpDgqAVKAD3IL3RF8mXY/c2d6vVjbSOnCOUcshc uX2zno7W2K73UnvEJ2uT8bald/vtf9m3Hp2lzQQTWVZc0Wjp8ZxSB16vCfaNLg16FS ELgCaQJtbxOohQQ2sl9uOOPgilv5lSsk2V+FWaJU= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7319170310 for ; Wed, 27 Jan 2021 21:28:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7319170310 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1l4pYU-0004iz-J1; Wed, 27 Jan 2021 21:28:39 +0300 Date: Wed, 27 Jan 2021 21:26:54 +0300 To: sergeyb@tarantool.org Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210127182654.3lu6ag352yufsbh5@tkn_work_nb> References: <4a34a0310b2529d4d85c534eb05802b0d7076c9b.1611765145.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4a34a0310b2529d4d85c534eb05802b0d7076c9b.1611765145.git.sergeyb@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92BC6D7A73B5E1EC9A4696E262F57B05E134BE683453920D000894C459B0CD1B967A3717FD9003778C5D6E5807738BA1AAD89B9A4C00A0809852F988894FAF51A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3295C83650092F9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AAEFEF2B38A4D0058638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC21CA239ED32DDDB00B19B2BE0A9710DEF31A5B25266E955D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C015BBC38BE64FE4678941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22494D58934CB00B3C3D76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B21B6F65FB21117FC3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7CD707F342D9BDC9867F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C31BC2FD6A5287AC5335872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C908A0C43E5267459C574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A50055C379E4D18F3C2357612EB760401B7AE9379CEE79EC24D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34128DEC38EFF4BE5A6AEF550C6B6C3B370E5305381E16CA84CBB18B6811691098465930A4A46AC0F81D7E09C32AA3244C9170A30F8ED953604FC232A5B6CD596733C9DC155518937F729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5ZUBkD5pAd9JzfUNsBv1/A== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE67A3717FD9003778C5D6E5807738BA1AB7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1] static-build: use hashes of downloaded files X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jan 27, 2021 at 07:37:01PM +0300, sergeyb@tarantool.org wrote: > From: Sergey Bronnikov > > Using hashes in ExternalProject_Add() [1] allows to avoid extra > downloads on rebuilds. > > 1. https://cmake.org/cmake/help/latest/module/ExternalProject.html > > Closes #5761 I don't know this machinery much, but it looks worthful and I don't see any downsides. LGTM. > diff --git a/static-build/CMakeLists.txt b/static-build/CMakeLists.txt > index 9a2f85052..39cb321d0 100644 > --- a/static-build/CMakeLists.txt > +++ b/static-build/CMakeLists.txt > @@ -40,6 +40,7 @@ endif() > # > ExternalProject_Add(openssl > URL https://www.openssl.org/source/openssl-${OPENSSL_VERSION}.tar.gz > + URL_MD5 3f486f2f4435ef14b81814dbbc7b48bb Nit: I would place certain hash values near to the versions block to don't spread dependent information and descrease probability to forget to update a checksum together with a version.