From: Alexander Turenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Bronnikov <sergeyb@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 3/4] test: enable SO_REUSEADDR on socket in httpd.py
Date: Thu, 14 Jan 2021 15:51:36 +0300 [thread overview]
Message-ID: <20210114125136.wv4syypi3aocyztn@tkn_work_nb> (raw)
In-Reply-To: <494197e4-fb8c-f4f6-d2c9-9fe129ebfaa0@tarantool.org>
On Thu, Jan 14, 2021 at 12:57:21PM +0300, Sergey Bronnikov wrote:
> Thanks for review!
>
> On 14.01.2021 12:09, Leonid Vasiliev wrote:
> > Hi! Thank you for the patch.
> > LGTM.
> >
> > This is a popular technique.
> > But I don't understand:"Why is it needed when python3 is used, but not
> > needed for python2?" If you know, share with me, if not, let it remain a
> > mystery.
>
> Last two commits are not related to python 3 support and I didn't state it.
>
> These patches are useful changes that I decided to add to the series.
I would suggest to send such patches separately in a future to avoid
such confusion.
next prev parent reply other threads:[~2021-01-14 12:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 8:48 [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Sergey Bronnikov via Tarantool-patches
2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 1/4] test: fix app-tap/http_client.test.lua Sergey Bronnikov via Tarantool-patches
2021-01-14 8:47 ` Leonid Vasiliev via Tarantool-patches
2021-01-14 9:50 ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:23 ` Alexander Turenko via Tarantool-patches
2021-01-14 12:52 ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:57 ` Alexander Turenko via Tarantool-patches
2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 2/4] test: fix xlog-py/big_lsn.test.py Sergey Bronnikov via Tarantool-patches
2021-01-14 9:02 ` Leonid Vasiliev via Tarantool-patches
2021-01-14 9:51 ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:38 ` Alexander Turenko via Tarantool-patches
2021-01-14 12:52 ` Sergey Bronnikov via Tarantool-patches
2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 3/4] test: enable SO_REUSEADDR on socket in httpd.py Sergey Bronnikov via Tarantool-patches
2021-01-13 19:59 ` Cyrill Gorcunov via Tarantool-patches
2021-01-14 9:09 ` Leonid Vasiliev via Tarantool-patches
2021-01-14 9:57 ` Sergey Bronnikov via Tarantool-patches
2021-01-14 12:51 ` Alexander Turenko via Tarantool-patches [this message]
2021-01-13 8:48 ` [Tarantool-patches] [PATCH v1 4/4] test: enable disabled testcases back Sergey Bronnikov via Tarantool-patches
2021-01-14 9:10 ` Leonid Vasiliev via Tarantool-patches
2021-01-13 20:03 ` [Tarantool-patches] [PATCH v1 0/4] Support Python 3 in Tarantool tests Cyrill Gorcunov via Tarantool-patches
2021-01-14 11:10 ` Leonid Vasiliev via Tarantool-patches
2021-01-15 9:34 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114125136.wv4syypi3aocyztn@tkn_work_nb \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 3/4] test: enable SO_REUSEADDR on socket in httpd.py' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox