From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 0/3] LuaJIT memory profiler bug fixes
Date: Wed, 30 Dec 2020 11:24:03 +0300 [thread overview]
Message-ID: <20201230082403.GA9301@hpalx> (raw)
In-Reply-To: <cover.1609278043.git.skaplun@tarantool.org>
Hi Sergey, thanks for the patchset, as I see no new degradation found in
gitlab-ci testing commit criteria pipeline [1], patchset LGTM.
[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/235622340
On Wed, Dec 30, 2020 at 01:22:55AM +0300, Sergey Kaplun via Tarantool-patches wrote:
> This patchset accumulate different fixes for memory profiler bugs
> introduced in scope of [1].
>
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-misc-memprof-fixes
> Branch CI: https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-misc-memprof-fixes
>
> CI is red [2], [3] but it isn't related to the patch, AFAICS. It has failed
> before my commit (see [4], [5]).
> CI :https://gitlab.com/tarantool/tarantool/-/pipelines/235622340
>
> [1]: https://github.com/tarantool/tarantool/issues/5442
> [2]: https://gitlab.com/tarantool/tarantool/-/jobs/936802176
> [3]: https://gitlab.com/tarantool/tarantool/-/jobs/936802176
> [4]: https://gitlab.com/tarantool/tarantool/-/jobs/936547205#L4118
> [5]: https://gitlab.com/tarantool/tarantool/-/pipelines/235383279
>
> Sergey Kaplun (3):
> misc: fix build with disabled memory profiler
> core: fix resources leak in memory profiler
> core: remove excess assertion inside memprof
>
> src/lib_misc.c | 8 ++++----
> src/lj_errmsg.h | 2 +-
> src/lj_memprof.c | 18 +++++++++++-------
> 3 files changed, 16 insertions(+), 12 deletions(-)
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-12-30 8:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 22:22 Sergey Kaplun
2020-12-29 22:22 ` [Tarantool-patches] [PATCH luajit 1/3] misc: fix build with disabled memory profiler Sergey Kaplun
2020-12-30 8:49 ` Igor Munkin
2020-12-30 8:52 ` Sergey Kaplun
2020-12-30 9:42 ` Sergey Ostanevich
2020-12-29 22:22 ` [Tarantool-patches] [PATCH luajit 2/3] core: fix resources leak in " Sergey Kaplun
2020-12-30 9:06 ` Igor Munkin
2020-12-30 9:31 ` Sergey Ostanevich
2020-12-30 9:33 ` Sergey Kaplun
2020-12-30 9:32 ` Sergey Kaplun
2020-12-30 9:53 ` Sergey Ostanevich
2020-12-29 22:22 ` [Tarantool-patches] [PATCH luajit 3/3] core: remove excess assertion inside memprof Sergey Kaplun
2020-12-30 9:39 ` Igor Munkin
2020-12-30 9:50 ` Sergey Kaplun
2020-12-30 10:50 ` Sergey Ostanevich
2020-12-30 11:06 ` Sergey Kaplun
2020-12-30 8:24 ` Alexander V. Tikhonov [this message]
2020-12-30 11:20 ` [Tarantool-patches] [PATCH luajit 0/3] LuaJIT memory profiler bug fixes Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201230082403.GA9301@hpalx \
--to=avtikhon@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 0/3] LuaJIT memory profiler bug fixes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox