Re: [Tarantool-patches] [PATCH 3/3] test: new version for -e assert(false) test

[Alexander Turenko <alexander.turenko@tarantool.org>]

On Tue, Dec 29, 2020 at 07:25:35PM +0300, Artem Starshov wrote:
> Functions with timeout transferred to module
> test/app-tap/lua/process_timeout.lua for futher
> using in other tests.

Typo: futher -> further.

> 
> Before this version of test was already done,
> but by mistake older version was rebased on
> master.

BTW, I would mark all such commits as 'Follows up #4983'. It is a kind
of grouping and may help to navigate over the history in a future.

> -local fiber = require('fiber')
> -local clock = require('clock')
> -local ffi = require('ffi')
> -local fio = require('fio')
> -local errno = require('errno')
> +local common = require('process_timeout')

Why 'common', not 'process_timeout'?

> diff --git a/test/app-tap/lua/process_timeout.lua b/test/app-tap/lua/process_timeout.lua
> new file mode 100644
> index 000000000..141fb0e43
> --- /dev/null
> +++ b/test/app-tap/lua/process_timeout.lua

I would leave a comment that will describe a reason, why those functions
are necessary in presence of the 'popen' built-in module.