From: Kirill Yukhin <kyukhin@tarantool.org>
To: mechanik20051988 <mechanik20051988@tarantool.org>
Cc: mechanik20051988 <mechanik20.05.1988@gmail.com>,
tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4] memtx: change small allocator behavior
Date: Tue, 29 Dec 2020 10:43:16 +0000 [thread overview]
Message-ID: <20201229104316.fqjbzw65vvofpvpr@tarantool.org> (raw)
In-Reply-To: <20201225114520.18796-1-mechanik20051988@tarantool.org>
Hello,
On 25 Dec 14:45, mechanik20051988 via Tarantool-patches wrote:
> From: mechanik20051988 <mechanik20.05.1988@gmail.com>
>
> Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5216-fix-strange-allocator-behavior
>
> Cnanges in v4:
> Add actual_alloc_factor parameter to small_alloc_create
>
> Previously, in small allocator, memory pools
> were allocated at the request, which in the case
> of a small slab_alloc_factor led to use
> pools with incorrect sizes. This patch changed
> small allocator behavior, now we allocate pools
> on the stage of allocator creation. Also we use
> special function to find appropriate pool, which
> is faster, then previous version with rbtree.
> This change fixes #5216.
>
> Also moved a check, that the slab_alloc_factor is in
> the range (1.0, 2.0] from small allocator to memtx_engine.
> If factor is not in range change it to 1.0001 or 2.0 respectively
>
> Closes #5216
Checked into 1.10, 2.5, 2.6 and master. Small updated.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-12-29 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 11:45 mechanik20051988
2020-12-25 11:45 ` [Tarantool-patches] [PATCH v4] small: changed small allocator pool management mechanik20051988
2020-12-28 12:11 ` [Tarantool-patches] [PATCH v4] memtx: change small allocator behavior Vladislav Shpilevoy
2020-12-28 14:11 ` Alexander V. Tikhonov
2020-12-29 10:43 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229104316.fqjbzw65vvofpvpr@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=mechanik20.05.1988@gmail.com \
--cc=mechanik20051988@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4] memtx: change small allocator behavior' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox