From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5BF574765E0 for ; Tue, 29 Dec 2020 13:43:20 +0300 (MSK) Date: Tue, 29 Dec 2020 10:43:16 +0000 From: Kirill Yukhin Message-ID: <20201229104316.fqjbzw65vvofpvpr@tarantool.org> References: <20201225114520.18796-1-mechanik20051988@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201225114520.18796-1-mechanik20051988@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4] memtx: change small allocator behavior List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mechanik20051988 Cc: mechanik20051988 , tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 25 Dec 14:45, mechanik20051988 via Tarantool-patches wrote: > From: mechanik20051988 > > Branch: https://github.com/tarantool/tarantool/tree/mechanik20051988/gh-5216-fix-strange-allocator-behavior > > Cnanges in v4: > Add actual_alloc_factor parameter to small_alloc_create > > Previously, in small allocator, memory pools > were allocated at the request, which in the case > of a small slab_alloc_factor led to use > pools with incorrect sizes. This patch changed > small allocator behavior, now we allocate pools > on the stage of allocator creation. Also we use > special function to find appropriate pool, which > is faster, then previous version with rbtree. > This change fixes #5216. > > Also moved a check, that the slab_alloc_factor is in > the range (1.0, 2.0] from small allocator to memtx_engine. > If factor is not in range change it to 1.0001 or 2.0 respectively > > Closes #5216 Checked into 1.10, 2.5, 2.6 and master. Small updated. -- Regards, Kirill Yukhin