* [Tarantool-patches] [PATCH] box: fix arguments passed to error message
@ 2020-12-28 9:30 Serge Petrenko
2020-12-28 9:33 ` Cyrill Gorcunov
2020-12-28 11:01 ` Kirill Yukhin
0 siblings, 2 replies; 3+ messages in thread
From: Serge Petrenko @ 2020-12-28 9:30 UTC (permalink / raw)
To: kyukhin, gorcunov; +Cc: tarantool-patches
box_wait_quorum() had an extraneous argument to error format string.
Remove it.
Found by Coverity.
CID 1500387
Follow-up #5435
---
sp/coverity-warn
Please, push to 2.6 and master.
src/box/box.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/box/box.cc b/src/box/box.cc
index e1d8305c8..f2f5bedb4 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -1229,7 +1229,7 @@ box_wait_quorum(uint32_t lead_id, int64_t target_lsn, int quorum,
if (ack_count < quorum) {
diag_set(ClientError, ER_QUORUM_WAIT, quorum, tt_sprintf(
"timeout after %.2lf seconds, collected %d acks",
- timeout, ack_count, quorum));
+ timeout, ack_count));
return -1;
}
return 0;
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH] box: fix arguments passed to error message
2020-12-28 9:30 [Tarantool-patches] [PATCH] box: fix arguments passed to error message Serge Petrenko
@ 2020-12-28 9:33 ` Cyrill Gorcunov
2020-12-28 11:01 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Cyrill Gorcunov @ 2020-12-28 9:33 UTC (permalink / raw)
To: Serge Petrenko; +Cc: tarantool-patches
On Mon, Dec 28, 2020 at 12:30:21PM +0300, Serge Petrenko wrote:
> box_wait_quorum() had an extraneous argument to error format string.
> Remove it.
> Found by Coverity.
>
> CID 1500387
> Follow-up #5435
Ack
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Tarantool-patches] [PATCH] box: fix arguments passed to error message
2020-12-28 9:30 [Tarantool-patches] [PATCH] box: fix arguments passed to error message Serge Petrenko
2020-12-28 9:33 ` Cyrill Gorcunov
@ 2020-12-28 11:01 ` Kirill Yukhin
1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin @ 2020-12-28 11:01 UTC (permalink / raw)
To: Serge Petrenko; +Cc: tarantool-patches
Hello,
On 28 Dec 12:30, Serge Petrenko wrote:
> box_wait_quorum() had an extraneous argument to error format string.
> Remove it.
> Found by Coverity.
>
> CID 1500387
> Follow-up #5435
> ---
> sp/coverity-warn
> Please, push to 2.6 and master.
I've checked your patch into 2.6 and master as obvious.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-28 11:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-28 9:30 [Tarantool-patches] [PATCH] box: fix arguments passed to error message Serge Petrenko
2020-12-28 9:33 ` Cyrill Gorcunov
2020-12-28 11:01 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox