Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko <sergepetrenko@tarantool.org>
To: kyukhin@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] box: fix arguments passed to error message
Date: Mon, 28 Dec 2020 12:30:21 +0300	[thread overview]
Message-ID: <20201228093021.57321-1-sergepetrenko@tarantool.org> (raw)

box_wait_quorum() had an extraneous argument to error format string.
Remove it.
Found by Coverity.

CID 1500387
Follow-up #5435
Please, push to 2.6 and master.

 src/box/box.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/box/box.cc b/src/box/box.cc
index e1d8305c8..f2f5bedb4 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -1229,7 +1229,7 @@ box_wait_quorum(uint32_t lead_id, int64_t target_lsn, int quorum,
 	if (ack_count < quorum) {
 		diag_set(ClientError, ER_QUORUM_WAIT, quorum, tt_sprintf(
 			 "timeout after %.2lf seconds, collected %d acks",
-			 timeout, ack_count, quorum));
+			 timeout, ack_count));
 		return -1;
 	return 0;
2.24.3 (Apple Git-128)

             reply	other threads:[~2020-12-28  9:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28  9:30 Serge Petrenko [this message]
2020-12-28  9:33 ` Cyrill Gorcunov
2020-12-28 11:01 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201228093021.57321-1-sergepetrenko@tarantool.org \
    --to=sergepetrenko@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] box: fix arguments passed to error message' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox