From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 583B84765E0 for ; Mon, 28 Dec 2020 12:30:35 +0300 (MSK) From: Serge Petrenko Date: Mon, 28 Dec 2020 12:30:21 +0300 Message-Id: <20201228093021.57321-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH] box: fix arguments passed to error message List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kyukhin@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org box_wait_quorum() had an extraneous argument to error format string. Remove it. Found by Coverity. CID 1500387 Follow-up #5435 --- sp/coverity-warn Please, push to 2.6 and master. src/box/box.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/box/box.cc b/src/box/box.cc index e1d8305c8..f2f5bedb4 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1229,7 +1229,7 @@ box_wait_quorum(uint32_t lead_id, int64_t target_lsn, int quorum, if (ack_count < quorum) { diag_set(ClientError, ER_QUORUM_WAIT, quorum, tt_sprintf( "timeout after %.2lf seconds, collected %d acks", - timeout, ack_count, quorum)); + timeout, ack_count)); return -1; } return 0; -- 2.24.3 (Apple Git-128)