From: Igor Munkin <imun@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: embed LuaJIT memory profiler tools
Date: Mon, 28 Dec 2020 11:17:03 +0300 [thread overview]
Message-ID: <20201228081703.GU5396@tarantool.org> (raw)
In-Reply-To: <20201228070431.31068-1-skaplun@tarantool.org>
Sergey,
On 28.12.20, Sergey Kaplun wrote:
> This patch embeds a parser for binary data dumped via the memory
> profiler to Tarantool binary.
>
> It is a set of the following Lua modules:
> * utils/bufread.lua: read binary data from a file.
> * utils/symtab.lua: symbol table decode functions
> * memprof/parse.lua: decode the memory profiler event stream
> * memprof/humanize.lua: display decoded data in human readable format
> * memprof.lua: Lua script and module to display data
>
> It launch with the following command:
> $ tarantool -e 'require("memprof")(arg[1])' - filename.bin
>
> Closed #5490
> ---
>
> Issue: https://github.com/tarantool/tarantool/issues/5490
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5442-luajit-memory-profiler
> CI: https://gitlab.com/tarantool/tarantool/-/commits/skaplun/gh-5442-luajit-memory-profiler
I've checked your patch master.
>
<snipped>
>
> --
> 2.28.0
>
--
Best regards,
IM
prev parent reply other threads:[~2020-12-28 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 7:04 Sergey Kaplun
2020-12-28 7:09 ` Igor Munkin
2020-12-28 7:10 ` Sergey Kaplun
2020-12-28 7:55 ` Alexander V. Tikhonov
2020-12-28 8:17 ` Igor Munkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228081703.GU5396@tarantool.org \
--to=imun@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] build: embed LuaJIT memory profiler tools' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox