Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH] cfg: fix format in error message
@ 2020-12-26 21:38 Cyrill Gorcunov
  2020-12-26 22:00 ` Cyrill Gorcunov
  2020-12-28 11:03 ` Kirill Yukhin
  0 siblings, 2 replies; 5+ messages in thread
From: Cyrill Gorcunov @ 2020-12-26 21:38 UTC (permalink / raw)
  To: tml; +Cc: Vladislav Shpilevoy

Coverity pointed that quorum value is int64_t
wide and could be trimmed in error message. Fix
it using proper formatting.

CID 1500388
Part-of #5446

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
branch gorcunov/gh-5446-fixup
for 2.6 and 2.5

 src/box/box.cc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/box/box.cc b/src/box/box.cc
index e1d8305c8..3c5873e3c 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -623,10 +623,10 @@ box_eval_replication_synchro_quorum(int nr_replicas)
 	if (quorum <= 0 || quorum >= VCLOCK_MAX) {
 		const char *msg =
 			tt_sprintf("the formula is evaluated "
-				   "to the quorum %d for replica "
+				   "to the quorum %lld for replica "
 				   "number %d, which is out of range "
-				   "[%d;%d]",
-				   quorum, nr_replicas, 1, VCLOCK_MAX - 1);
+				   "[%d;%d]", (long long)quorum,
+				   nr_replicas, 1, VCLOCK_MAX - 1);
 		diag_set(ClientError, ER_CFG,
 			 "replication_synchro_quorum", msg);
 		return -1;
-- 
2.26.2

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-12-28 11:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 21:38 [Tarantool-patches] [PATCH] cfg: fix format in error message Cyrill Gorcunov
2020-12-26 22:00 ` Cyrill Gorcunov
2020-12-28  7:47   ` Alexander V. Tikhonov
2020-12-28  7:53     ` Cyrill Gorcunov
2020-12-28 11:03 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox