Re: [Tarantool-patches] [PATCH] build: embed LuaJIT memory profiler tools

[Sergey Kaplun <skaplun@tarantool.org>]

Igor,

On 28.12.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM except a single nit.
> 
> On 28.12.20, Sergey Kaplun wrote:
> > This patch embeds a parser for binary data dumped via the memory
> > profiler to Tarantool binary.
> > 
> > It is a set of the following Lua modules:
> > * utils/bufread.lua: read binary data from a file.
> > * utils/symtab.lua: symbol table decode functions
> > * memprof/parse.lua: decode the memory profiler event stream
> > * memprof/humanize.lua: display decoded data in human readable format
> > * memprof.lua: Lua script and module to display data
> > 
> > It launch with the following command:
> > $ tarantool -e 'require("memprof")(arg[1])' - filename.bin
> > 
> > Closed #5490
> 
> Typo: s/Closed/Closes/.

Fixed and repushed branch with --force.

> 
> > ---
> > 
> > Issue: https://github.com/tarantool/tarantool/issues/5490
> > Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5442-luajit-memory-profiler
> > CI: https://gitlab.com/tarantool/tarantool/-/commits/skaplun/gh-5442-luajit-memory-profiler
> > 
> >  src/CMakeLists.txt |  6 ++++++
> >  src/lua/init.c     | 15 ++++++++++++++-
> >  2 files changed, 20 insertions(+), 1 deletion(-)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.28.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun