From: Sergey Kaplun <skaplun@tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 2/7] core: introduce write buffer module
Date: Mon, 28 Dec 2020 04:43:26 +0300 [thread overview]
Message-ID: <20201228014326.GG14702@root> (raw)
In-Reply-To: <20201226193741.GY9101@root>
Fixed warning "pointer of type ‘void *’ used in arithmetic [-Wpointer-arith]"
Changed naming.
See iterative patch below. Branch will be force-pushed later with
v3 series.
===================================================================
diff --git a/src/lj_wbuf.c b/src/lj_wbuf.c
index ef46545..897ef08 100644
--- a/src/lj_wbuf.c
+++ b/src/lj_wbuf.c
@@ -90,7 +90,7 @@ void lj_wbuf_addn(struct lj_wbuf *buf, const void *src, size_t n)
memcpy(buf->pos, src, left);
buf->pos += (ptrdiff_t)left;
lj_wbuf_flush(buf);
- src += (ptrdiff_t)left;
+ src = (uint8_t *)src + (ptrdiff_t)left;
n -= left;
}
@@ -120,7 +120,7 @@ void LJ_FASTCALL lj_wbuf_flush(struct lj_wbuf *buf)
written = buf->writer((const void **)&buf->buf, len, buf->ctx);
if (LJ_UNLIKELY(written < len)) {
- wbuf_set_flag(buf, STREAM_ERR_IO);
+ wbuf_set_flag(buf, STREAM_ERRIO);
wbuf_save_errno(buf);
}
if (LJ_UNLIKELY(buf->buf == NULL)) {
diff --git a/src/lj_wbuf.h b/src/lj_wbuf.h
index 77a7cf4..9eaa5e5 100644
--- a/src/lj_wbuf.h
+++ b/src/lj_wbuf.h
@@ -28,7 +28,7 @@
*/
/* Stream errors. */
-#define STREAM_ERR_IO 0x1
+#define STREAM_ERRIO 0x1
#define STREAM_STOP 0x2
/*
===================================================================
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2020-12-28 1:44 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 15:26 [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer Sergey Kaplun
2020-12-25 21:42 ` Igor Munkin
2020-12-26 9:32 ` Sergey Kaplun
2020-12-26 13:57 ` Sergey Kaplun
2020-12-26 18:47 ` Sergey Ostanevich
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 2/7] core: introduce write buffer module Sergey Kaplun
2020-12-26 14:22 ` Igor Munkin
2020-12-26 15:26 ` Sergey Kaplun
2020-12-26 19:03 ` Sergey Ostanevich
2020-12-26 19:37 ` Sergey Kaplun
2020-12-28 1:43 ` Sergey Kaplun [this message]
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun
2020-12-26 19:07 ` Sergey Ostanevich
2020-12-27 23:48 ` Igor Munkin
2020-12-28 3:54 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 4/7] core: introduce new mem_L field Sergey Kaplun
2020-12-26 19:12 ` Sergey Ostanevich
2020-12-26 19:42 ` Sergey Kaplun
2020-12-27 13:09 ` Igor Munkin
2020-12-27 17:44 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 5/7] core: introduce memory profiler Sergey Kaplun
2020-12-27 10:58 ` Sergey Ostanevich
2020-12-27 11:54 ` Sergey Kaplun
2020-12-27 13:27 ` Sergey Ostanevich
2020-12-27 16:44 ` Igor Munkin
2020-12-27 21:47 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 6/7] misc: add Lua API for " Sergey Kaplun
2020-12-27 11:54 ` Sergey Ostanevich
2020-12-27 13:42 ` Sergey Kaplun
2020-12-27 15:37 ` Sergey Ostanevich
2020-12-27 18:58 ` Igor Munkin
2020-12-28 0:14 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 7/7] tools: introduce a memory profile parser Sergey Kaplun
2020-12-26 22:56 ` Igor Munkin
2020-12-27 7:16 ` Sergey Kaplun
2020-12-28 5:30 ` Sergey Kaplun
2020-12-28 5:33 ` Igor Munkin
2020-12-28 6:28 ` Sergey Kaplun
2020-12-28 6:31 ` Igor Munkin
2020-12-27 13:24 ` Sergey Ostanevich
2020-12-27 16:02 ` Sergey Kaplun
2020-12-27 21:55 ` Sergey Ostanevich
2020-12-28 2:05 ` [Tarantool-patches] [PATCH luajit v3 2/2] misc: add Lua API for memory profiler Sergey Kaplun
2020-12-28 2:49 ` Igor Munkin
2020-12-28 5:19 ` Sergey Kaplun
2020-12-28 2:06 ` [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce " Sergey Kaplun
2020-12-28 3:59 ` Igor Munkin
2020-12-28 4:05 ` [Tarantool-patches] [PATCH luajit v3 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun
2020-12-28 5:14 ` Igor Munkin
2020-12-28 6:01 ` [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler Alexander V. Tikhonov
2020-12-28 8:15 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228014326.GG14702@root \
--to=skaplun@tarantool.org \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2 2/7] core: introduce write buffer module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox