From: Sergey Kaplun <skaplun@tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v1 04/11] profile: introduce symtab write module
Date: Fri, 25 Dec 2020 11:45:08 +0300 [thread overview]
Message-ID: <20201225084508.GP9101@root> (raw)
In-Reply-To: <20201224093628.GZ5396@tarantool.org>
Igor,
On 24.12.20, Igor Munkin wrote:
> Sergey,
>
> On 24.12.20, Sergey Kaplun wrote:
> > Igor,
> >
> > Thanks for the review!
> >
> > On 21.12.20, Igor Munkin wrote:
> > > Sergey,
> > >
> > > Thanks for the patch! Please consider minor comments below.
> > >
> > > On 16.12.20, Sergey Kaplun wrote:
>
> <snipped>
>
> > > > diff --git a/src/profile/ljp_symtab.c b/src/profile/ljp_symtab.c
> > > > new file mode 100644
> > > > index 0000000..5a17c97
> > > > --- /dev/null
> > > > +++ b/src/profile/ljp_symtab.c
> > > > @@ -0,0 +1,55 @@
> > >
> > > <snipped>
> > >
> > > > +#define LJS_CURRENT_VERSION 2
> > >
> > > Why is it already the second version?
> >
> > It's inherited from LuaVela. I didn't know is it right to drop version
> > to zero. But AFAICS from your comment it is :)
>
> Why zero? I believe the most natural way to number versions starts with
> the *first* version (zero versions are often considered as something not
> ready to be released or unstable). Anyway, this value breaks nothing and
> should be just incremented for the future symtab changes, so feel free
> to use zero, if you want.
Hmm, my bad. It's MVP, but stable MVP (as we suppose)(:. So lets use the
first verison.
>
> >
> > >
> > > > +
>
> <snipped>
>
> >
> > --
> > Best regards,
> > Sergey Kaplun
>
> --
> Best regards,
> IM
--
Best regards,
Sergey Kaplun
next prev parent reply other threads:[~2020-12-25 8:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 19:13 [Tarantool-patches] [PATCH luajit v1 00/11] LuaJIT memory profiler Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 01/11] build: add src dir in building Sergey Kaplun
2020-12-20 21:27 ` Igor Munkin
2020-12-23 18:20 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 02/11] utils: introduce leb128 reader and writer Sergey Kaplun
2020-12-20 22:44 ` Igor Munkin
2020-12-23 22:34 ` Sergey Kaplun
2020-12-24 9:11 ` Igor Munkin
2020-12-25 8:46 ` Sergey Kaplun
2020-12-23 16:50 ` Sergey Ostanevich
2020-12-23 22:36 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 03/11] profile: introduce profiler writing module Sergey Kaplun
2020-12-21 9:24 ` Igor Munkin
2020-12-24 6:46 ` Sergey Kaplun
2020-12-24 15:45 ` Sergey Ostanevich
2020-12-24 21:20 ` Sergey Kaplun
2020-12-25 9:37 ` Igor Munkin
2020-12-25 10:13 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 04/11] profile: introduce symtab write module Sergey Kaplun
2020-12-21 10:30 ` Igor Munkin
2020-12-24 7:00 ` Sergey Kaplun
2020-12-24 9:36 ` Igor Munkin
2020-12-25 8:45 ` Sergey Kaplun [this message]
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 05/11] vm: introduce LFUNC and FFUNC vmstates Sergey Kaplun
2020-12-25 11:07 ` Sergey Ostanevich
2020-12-25 11:23 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 06/11] core: introduce new mem_L field Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 07/11] debug: move debug_frameline to public module API Sergey Kaplun
2020-12-20 22:46 ` Igor Munkin
2020-12-24 6:50 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 08/11] profile: introduce memory profiler Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 09/11] misc: add Lua API for " Sergey Kaplun
2020-12-24 16:32 ` Sergey Ostanevich
2020-12-24 21:25 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 10/11] tools: introduce tools directory Sergey Kaplun
2020-12-20 22:46 ` Igor Munkin
2020-12-24 6:47 ` Sergey Kaplun
2020-12-16 19:13 ` [Tarantool-patches] [PATCH luajit v1 11/11] profile: introduce profile parser Sergey Kaplun
2020-12-24 23:09 ` Igor Munkin
2020-12-25 8:41 ` Sergey Kaplun
2020-12-21 10:43 ` [Tarantool-patches] [PATCH luajit v1 00/11] LuaJIT memory profiler Igor Munkin
2020-12-24 7:02 ` Sergey Kaplun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201225084508.GP9101@root \
--to=skaplun@tarantool.org \
--cc=imun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v1 04/11] profile: introduce symtab write module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox