From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server
Date: Thu, 24 Dec 2020 16:16:01 +0300 [thread overview]
Message-ID: <20201224131601.GB298600@grain> (raw)
In-Reply-To: <20201223212253.GA298600@grain>
On Thu, Dec 24, 2020 at 12:22:53AM +0300, Cyrill Gorcunov wrote:
> On Wed, Dec 23, 2020 at 07:47:44PM +0100, Vladislav Shpilevoy wrote:
> > Hi! Thanks for the patch!
> >
> > See 3 comments and fixes below, and top of the branch in a
> > separate commit.
> >
>
> Vlad, since we can use json_escape I dropped usage of base64
> encoder for backtrace. The final interdiff I pushed into
> gorcunov/gh-5261-crash-report-6 is the following
FWIW gorcunov/gh-5261-crash-report-6 passes all tests
https://gitlab.com/tarantool/tarantool/-/pipelines/234153923
next prev parent reply other threads:[~2020-12-24 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 15:41 [Tarantool-patches] [PATCH v5 0/4] Our feedback daemon sends only a few portions of usage Cyrill Gorcunov
2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 1/4] util: introduce strlcpy helper Cyrill Gorcunov
2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 2/4] backtrace: allow to specify destination buffer Cyrill Gorcunov
2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 3/4] crash: move fatal signal handling in Cyrill Gorcunov
2020-12-23 15:41 ` [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server Cyrill Gorcunov
2020-12-23 18:47 ` Vladislav Shpilevoy
2020-12-23 18:57 ` Cyrill Gorcunov
2020-12-23 21:22 ` Cyrill Gorcunov
2020-12-24 13:16 ` Cyrill Gorcunov [this message]
2020-12-24 17:15 ` Vladislav Shpilevoy
2020-12-24 17:33 ` Cyrill Gorcunov
2020-12-24 18:22 ` Vladislav Shpilevoy
2020-12-24 18:33 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224131601.GB298600@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to the feedback server' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox