From: Kirill Yukhin <kyukhin@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: Michael Filonenko <filonenko.mikhail@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] lua: avoid panic if HOOK_GC is not active
Date: Wed, 23 Dec 2020 13:05:04 +0000 [thread overview]
Message-ID: <20201223130504.szb3x6sdj5p6mijy@tarantool.org> (raw)
In-Reply-To: <20201222130858.16812-1-skaplun@tarantool.org>
Hello,
On 22 Dec 16:08, Sergey Kaplun via Tarantool-patches wrote:
> Panic at fiber.yield() occures inside any active hook.
>
> This is the regression from 96dbc49d097a96af5273cce2b5663db5917f4ea9
> ('lua: prohibit fiber yield when GC hook is active').
>
> This patch fixes false positive panic in cases when VM is not running
> a GC hook.
>
> Reported-by: Michael Filonenko <filonenko.mikhail@gmail.com>
> Follows up #4727
> Closes #5649
I've checked your patch into 1.10, 2.5, 2.6 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-12-23 13:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 13:08 Sergey Kaplun
2020-12-22 16:05 ` Igor Munkin
2020-12-22 16:09 ` Igor Munkin
2020-12-22 17:51 ` Sergey Kaplun
2020-12-22 17:55 ` Sergey Kaplun
2020-12-22 16:37 ` Sergey Ostanevich
2020-12-22 17:47 ` Sergey Kaplun
2020-12-22 18:01 ` Sergey Kaplun
2020-12-23 9:47 ` Sergey Ostanevich
2020-12-23 10:23 ` Alexander V. Tikhonov
2020-12-23 13:05 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223130504.szb3x6sdj5p6mijy@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=filonenko.mikhail@gmail.com \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] lua: avoid panic if HOOK_GC is not active' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox