[Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Alexander V. Tikhonov]

Added packaging jobs for Fedora 32.

Closes #4966

(cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)
Also added job to travis-ci.
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
Issue: https://github.com/tarantool/tarantool/issues/4966

The patch should be committed only after commit
  bdd90686f82ec2e22d4ea7adfb9a6173bcc8af4a
will be pushed to be able to fix Fedoar 32 build.

Also current fix is on for 1.10 branch only, for other branches
need to make changes in .travis.yml changes:
2.4: 1.10 -> 2.4
2.3: 1.10 -> 2.3
2.2: 1.10 -> 2.2
For master branch .travis.yml doesn't need to be updated.
Use 5613beedf83a679b725cea816a4176eabe3e1601 for master branch.

 .gitlab-ci.yml | 12 ++++++++++++
 .travis.yml    |  3 +++
 2 files changed, 15 insertions(+)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cf445c638..fc0539927 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -328,6 +328,12 @@ fedora_31:
     OS: 'fedora'
     DIST: '31'
 
+fedora_32:
+  <<: *pack_test_definition
+  variables:
+    OS: 'fedora'
+    DIST: '32'
+
 ubuntu_14_04:
   <<: *pack_definition
   variables:
@@ -425,6 +431,12 @@ fedora_31_deploy:
     OS: 'fedora'
     DIST: '31'
 
+fedora_32_deploy:
+  <<: *deploy_test_definition
+  variables:
+    OS: 'fedora'
+    DIST: '32'
+
 ubuntu_14_04_deploy:
   <<: *deploy_definition
   variables:
diff --git a/.travis.yml b/.travis.yml
index a09f511dc..4cf2428ea 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -50,6 +50,9 @@ jobs:
       - name: "Fedora 31 build + test + deploy RPM"
         env: OS=fedora DIST=31
         if: branch = "1.10"
+      - name: "Fedora 32 build + test + deploy RPM"
+        env: OS=fedora DIST=32
+        if: branch = "1.10"
       - name: "Ubuntu Trusty (14.04) build + deploy DEB"
         env: OS=ubuntu DIST=trusty
         if: branch = "1.10"
-- 
2.17.1

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Alexander Turenko]

On Sun, Jun 07, 2020 at 04:40:40PM +0300, Alexander V. Tikhonov wrote:
> Added packaging jobs for Fedora 32.
> 
> Closes #4966
> 
> (cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)

Are you added 'cherry picked from' by mistake?

> Also added job to travis-ci.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4966
> 
> The patch should be committed only after commit
>   bdd90686f82ec2e22d4ea7adfb9a6173bcc8af4a
> will be pushed to be able to fix Fedoar 32 build.

It should not be pushed until all warnings from [1] will be resolved or
at least will be proven to be false-positive.

[1]: https://github.com/tarantool/tarantool/issues/4966

> 
> Also current fix is on for 1.10 branch only, for other branches
> need to make changes in .travis.yml changes:
> 2.4: 1.10 -> 2.4
> 2.3: 1.10 -> 2.3
> 2.2: 1.10 -> 2.2
> For master branch .travis.yml doesn't need to be updated.
> Use 5613beedf83a679b725cea816a4176eabe3e1601 for master branch.

I would rather implement the patch on top of master and mention what
should be done after cherry-picking for 2.4, 2.3 and 1.10.

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Alexander V. Tikhonov]

Hi Alexander, thanks for the review. Please check my comments below.

On Sun, Jun 07, 2020 at 05:03:46PM +0300, Alexander Turenko wrote:
> On Sun, Jun 07, 2020 at 04:40:40PM +0300, Alexander V. Tikhonov wrote:
> > Added packaging jobs for Fedora 32.
> > 
> > Closes #4966
> > 
> > (cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)
> 
> Are you added 'cherry picked from' by mistake?
> 

Right the wrong branch was used, in real branch to be used is:
  avtikhon/gh-4966-fedora-32-full-ci

> > Also added job to travis-ci.
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
> > Issue: https://github.com/tarantool/tarantool/issues/4966
> > 
> > The patch should be committed only after commit
> >   bdd90686f82ec2e22d4ea7adfb9a6173bcc8af4a
> > will be pushed to be able to fix Fedoar 32 build.
> 
> It should not be pushed until all warnings from [1] will be resolved or
> at least will be proven to be false-positive.
> 
> [1]: https://github.com/tarantool/tarantool/issues/4966
>

Right, issue #4966 is fixed and closed for now.

> > 
> > Also current fix is on for 1.10 branch only, for other branches
> > need to make changes in .travis.yml changes:
> > 2.4: 1.10 -> 2.4
> > 2.3: 1.10 -> 2.3
> > 2.2: 1.10 -> 2.2
> > For master branch .travis.yml doesn't need to be updated.
> > Use 5613beedf83a679b725cea816a4176eabe3e1601 for master branch.
> 
> I would rather implement the patch on top of master and mention what
> should be done after cherry-picking for 2.4, 2.3 and 1.10.

Not needed for now, due to travis-ci is not used any more.

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Oleg Koshovetc]

LGTM

Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for Fedora 32

[Kirill Yukhin]

Hello,

On 07 Jun 16:40, Alexander V. Tikhonov wrote:
> Added packaging jobs for Fedora 32.
> 
> Closes #4966
> 
> (cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)
> Also added job to travis-ci.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4966

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin