Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: filter replication/skip_conflict_row output
Date: Wed, 23 Dec 2020 12:38:58 +0000	[thread overview]
Message-ID: <20201223123858.v6vhv3jq4vb63eng@tarantool.org> (raw)
In-Reply-To: <8de6627a70dfda2cbe72d5e173836e717495be42.1608489860.git.avtikhon@tarantool.org>

Hello,

On 20 Dec 21:45, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that test replication/skip_conflict_row.test.lua fails with
> output message in results file:
> 
>   [035] @@ -139,7 +139,19 @@
>   [035]  -- applier is not in follow state
>   [035]  test_run:wait_upstream(1, {status = 'stopped', message_re = "Duplicate key exists in unique index 'primary' in space 'test'"})
>   [035]  ---
>   [035] -- true
>   [035] +- false
>   [035] +- id: 1
>   [035] +  uuid: f2084d3c-93f2-4267-925f-015df034d0a5
>   [035] +  lsn: 553
>   [035] +  upstream:
>   [035] +    status: follow
>   [035] +    idle: 0.0024020448327065
>   [035] +    peer: unix/:/builds/4BUsapPU/0/tarantool/tarantool/test/var/035_replication/master.socket-iproto
>   [035] +    lag: 0.0046234130859375
>   [035] +  downstream:
>   [035] +    status: follow
>   [035] +    idle: 0.086121961474419
>   [035] +    vclock: {2: 3, 1: 553}
>   [035]  ...
>   [035]  --
>   [035]  -- gh-3977: check that NOP is written instead of conflicting row.
> 
> Test could not be restarted with checksum because of changing values
> like UUID on each fail. It happend because test-run uses internal
> chain of functions wait_upstream() -> gen_box_info_replication_cond()
> which returns instance information on its fails. To avoid of it this
> output was redirected to log file instead of results file.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/skip_cond_2nd2

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2020-12-23 12:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 18:45 Alexander V. Tikhonov
2020-12-20 19:10 ` Oleg Koshovetc
2020-12-23 12:38 ` Kirill Yukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201223123858.v6vhv3jq4vb63eng@tarantool.org \
    --to=kyukhin@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: filter replication/skip_conflict_row output' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox