From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F37E54765E7
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 23 Dec 2020 15:39:01 +0300 (MSK)
Date: Wed, 23 Dec 2020 12:38:58 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201223123858.v6vhv3jq4vb63eng@tarantool.org>
References: <8de6627a70dfda2cbe72d5e173836e717495be42.1608489860.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8de6627a70dfda2cbe72d5e173836e717495be42.1608489860.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: filter
	replication/skip_conflict_row output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 20 Dec 21:45, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that test replication/skip_conflict_row.test.lua fails with
> output message in results file:
> 
>   [035] @@ -139,7 +139,19 @@
>   [035]  -- applier is not in follow state
>   [035]  test_run:wait_upstream(1, {status = 'stopped', message_re = "Duplicate key exists in unique index 'primary' in space 'test'"})
>   [035]  ---
>   [035] -- true
>   [035] +- false
>   [035] +- id: 1
>   [035] +  uuid: f2084d3c-93f2-4267-925f-015df034d0a5
>   [035] +  lsn: 553
>   [035] +  upstream:
>   [035] +    status: follow
>   [035] +    idle: 0.0024020448327065
>   [035] +    peer: unix/:/builds/4BUsapPU/0/tarantool/tarantool/test/var/035_replication/master.socket-iproto
>   [035] +    lag: 0.0046234130859375
>   [035] +  downstream:
>   [035] +    status: follow
>   [035] +    idle: 0.086121961474419
>   [035] +    vclock: {2: 3, 1: 553}
>   [035]  ...
>   [035]  --
>   [035]  -- gh-3977: check that NOP is written instead of conflicting row.
> 
> Test could not be restarted with checksum because of changing values
> like UUID on each fail. It happend because test-run uses internal
> chain of functions wait_upstream() -> gen_box_info_replication_cond()
> which returns instance information on its fails. To avoid of it this
> output was redirected to log file instead of results file.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/skip_cond_2nd2

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin