From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically
Date: Tue, 22 Dec 2020 17:32:40 +0300 [thread overview]
Message-ID: <20201222143240.GB8261@grain> (raw)
In-Reply-To: <8b570db3-858d-4475-1f9f-7e5c84321129@tarantool.org>
On Tue, Dec 22, 2020 at 02:49:06PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patchset!
>
> Looks good, except that the test is still flaky. I run it
> with the same command as earlier, and got this:
Vlad, I've increased timeout for console buffer flushing.
Could you please re-fetch the branch (I've force pushed it)
and test out?
The timeout trick doesn't look 100% reliable and I think
I will need to enhance the test to use new qsync statistics
(which is not yet done). Thus I'll make a linked issue for
this and once qsync stat is out we will fix the test for
sure.
next prev parent reply other threads:[~2020-12-22 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 11:14 Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 1/5] cfg: add cfg_isnumber helper Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 2/5] cfg: rework box_check_replication_synchro_quorum Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 3/5] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 4/5] cfg: more precise check for replication_synchro_quorum value Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 5/5] test: add replication/gh-5446-qsync-eval-quorum.test.lua Cyrill Gorcunov
2020-12-22 13:49 ` [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically Vladislav Shpilevoy
2020-12-22 13:53 ` Cyrill Gorcunov
2020-12-22 14:32 ` Cyrill Gorcunov [this message]
2020-12-22 17:13 ` Cyrill Gorcunov
2020-12-23 14:14 ` Vladislav Shpilevoy
2020-12-23 15:54 ` Cyrill Gorcunov
2020-12-23 17:52 ` Vladislav Shpilevoy
2020-12-24 13:55 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222143240.GB8261@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox