Re: [Tarantool-patches] [PATCH luajit v1 07/11] debug: move debug_frameline to public module API

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the patch! I doubt this change need to be made as a separate
patch. Anyway, I left a couple of nits below.

Furthermore, it's better to use 'core' prefix here, otherwise it's not
needed since every translation unit uses own one then.

On 16.12.20, Sergey Kaplun wrote:
> This patch renames debug_frameline to lj_debug_frameline and moves it to
> public <lj_debug.h> module API (does not provide it with LUA_API). It
> will be used for memory profiler in the next patches.

Minor: I propose more simple wording:
| core: make debug_frameline visible for other sources
|
| This change makes debug_frameline function LuaJIT-wide visible to be
| used in other subsystems (e.g. memory profiler).

> 
> Part of tarantool/tarantool#5442
> ---
>  src/lj_debug.c | 8 ++++----
>  src/lj_debug.h | 1 +
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 

<snipped>

> diff --git a/src/lj_debug.h b/src/lj_debug.h
> index 5917c00..1b5ef29 100644
> --- a/src/lj_debug.h
> +++ b/src/lj_debug.h
> @@ -40,6 +40,7 @@ LJ_FUNC void lj_debug_addloc(lua_State *L, const char *msg,
>  LJ_FUNC void lj_debug_pushloc(lua_State *L, GCproto *pt, BCPos pc);
>  LJ_FUNC int lj_debug_getinfo(lua_State *L, const char *what, lj_Debug *ar,
>  			     int ext);
> +LJ_FUNC BCLine lj_debug_frameline(lua_State *L, GCfunc *fn, cTValue *nextframe);

Minor: As you can see below, <lj_debug_dumpstack> is provided only if
profiler is enabled. Since this function is necessary only for memprof,
there is no need to make it LuaJIT-wide visible by default. This looks
more natural to me. This is not required but seems like a nice approach,
so feel free to ignore.

>  #if LJ_HASPROFILE
>  LJ_FUNC void lj_debug_dumpstack(lua_State *L, SBuf *sb, const char *fmt,
>  				int depth);
> -- 
> 2.28.0
> 

-- 
Best regards,
IM