From: Kirill Yukhin <kyukhin@tarantool.org>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] luacheck: change global vars to local in sql-tap
Date: Wed, 16 Dec 2020 12:03:31 +0000 [thread overview]
Message-ID: <20201216120331.ueiwe54h54g67hm2@tarantool.org> (raw)
In-Reply-To: <6356f57583254b766c44bd0e6edba3f8834d3a27.1607968875.git.artemreyt@tarantool.org>
Hello,
On 14 Dec 21:10, Artem Starshov via Tarantool-patches wrote:
> Fixed luacheck warning 111 (setting non-standard global variable)
> in test/sql-tap directory.
> Enabled this directory for checking W111 in
> config file(.luacheckrc).
>
> Changed almost all variables in test/sql-tap from globals
> to locals. In any cases, where variables need to be global,
> added explicit _G. prefix (table of globals).
>
> Fixes #5173
> Part-of #5464
> ---
> Changes in v3:
> - inline "globals" suppressions changed to _G usage
> - removed some unnecessary suppressions
> - rebased to master and corrected newly appeared tests
>
> See LGTM from AlexTu: https://lists.tarantool.org/pipermail/tarantool-patches/2020-December/021194.html
> Branch:https://github.com/tarantool/tarantool/tree/artemreyt/gh-5173-fix-luacheck-warnings-sql-tap
> Issue: https://github.com/tarantool/tarantool/issues/5173
LGTM.
I've checked your patch into 2.5, 2.6 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-12-16 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 18:10 Artem Starshov
2020-12-14 19:20 ` Alexander V. Tikhonov
2020-12-16 12:03 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216120331.ueiwe54h54g67hm2@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=artemreyt@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] luacheck: change global vars to local in sql-tap' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox