From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 82B4245C304
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Dec 2020 15:03:32 +0300 (MSK)
Date: Wed, 16 Dec 2020 12:03:31 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201216120331.ueiwe54h54g67hm2@tarantool.org>
References: <6356f57583254b766c44bd0e6edba3f8834d3a27.1607968875.git.artemreyt@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <6356f57583254b766c44bd0e6edba3f8834d3a27.1607968875.git.artemreyt@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3] luacheck: change global vars to
 local in sql-tap
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 14 Dec 21:10, Artem Starshov via Tarantool-patches wrote:
> Fixed luacheck warning 111 (setting non-standard global variable)
> in test/sql-tap directory.
> Enabled this directory for checking W111 in
> config file(.luacheckrc).
> 
> Changed almost all variables in test/sql-tap from globals
> to locals. In any cases, where variables need to be global,
> added explicit _G. prefix (table of globals).
> 
> Fixes #5173
> Part-of #5464
> ---
> Changes in v3:
>     - inline "globals" suppressions changed to _G usage
>     - removed some unnecessary suppressions
>     - rebased to master and corrected newly appeared tests
> 
> See LGTM from AlexTu: https://lists.tarantool.org/pipermail/tarantool-patches/2020-December/021194.html
> Branch:https://github.com/tarantool/tarantool/tree/artemreyt/gh-5173-fix-luacheck-warnings-sql-tap
> Issue: https://github.com/tarantool/tarantool/issues/5173

LGTM.
I've checked your patch into 2.5, 2.6 and master.

--
Regards, Kirill Yukhin