Tarantool development patches archive
 help / color / mirror / Atom feed
* [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test
@ 2020-12-08 16:19 Alexander V. Tikhonov
  2020-12-10 15:38 ` Oleg Koshovetc
  2020-12-11  9:17 ` Kirill Yukhin
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander V. Tikhonov @ 2020-12-08 16:19 UTC (permalink / raw)
  To: Kirill Yukhin; +Cc: tarantool-patches

Cc: tarantool-patches@dev.tarantool.org

Found issue:

  [079] @@ -115,5 +115,14 @@
  [079]  -- connection is deleted by 'collect'.
  [079]  weak.c
  [079]  ---
  [079] -- null
  [079] +- peer_uuid: 035d7b36-f205-45f4-9e16-e5b0b99a9b0b
  [079] +  opts:
  [079] +    reconnect_after: 0.1
  [079] +  host: unix/
  [079] +  schema_version: 78
  [079] +  protocol: Binary
  [079] +  state: error_reconnect
  [079] +  error: Connection refused
  [079] +  peer_version_id: 132864
  [079] +  port: /tmp/tnt/079_box/proxy.socket-iproto
  [079]  ...

Which could not be restarted with checksum because of changing UUID
value each run. To avoid of it added filter on 'peer_uuid:' output.
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/box-test-filter

 .../net.box_reconnect_after_gh-3164.result    | 20 +++++++++++++++++++
 .../net.box_reconnect_after_gh-3164.test.lua  |  6 ++++++
 test/box/suite.ini                            |  3 ++-
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/test/box/net.box_reconnect_after_gh-3164.result b/test/box/net.box_reconnect_after_gh-3164.result
index 216ce0366..f28674bb6 100644
--- a/test/box/net.box_reconnect_after_gh-3164.result
+++ b/test/box/net.box_reconnect_after_gh-3164.result
@@ -10,6 +10,26 @@ test_run = require('test_run').new()
 net = require('net.box')
 ---
 ...
+test_run:cmd("push filter 'peer_uuid: .*' to 'peer_uuid: <UUID>'")
+---
+- true
+...
+test_run:cmd("push filter 'reconnect_after: .*' to 'reconnect_after: <NUM>'")
+---
+- true
+...
+test_run:cmd("push filter 'schema_version: .*' to 'schema_version: <NUM>'")
+---
+- true
+...
+test_run:cmd("push filter 'peer_version_id: .*' to 'peer_version_id: <ID>'")
+---
+- true
+...
+test_run:cmd("push filter 'port: .*' to 'port: <PORT>'")
+---
+- true
+...
 test_run:cmd('create server connecter with script = "box/proxy.lua"')
 ---
 - true
diff --git a/test/box/net.box_reconnect_after_gh-3164.test.lua b/test/box/net.box_reconnect_after_gh-3164.test.lua
index dc2747080..085ce018f 100644
--- a/test/box/net.box_reconnect_after_gh-3164.test.lua
+++ b/test/box/net.box_reconnect_after_gh-3164.test.lua
@@ -3,6 +3,12 @@ log = require 'log'
 test_run = require('test_run').new()
 net = require('net.box')
 
+test_run:cmd("push filter 'peer_uuid: .*' to 'peer_uuid: <UUID>'")
+test_run:cmd("push filter 'reconnect_after: .*' to 'reconnect_after: <NUM>'")
+test_run:cmd("push filter 'schema_version: .*' to 'schema_version: <NUM>'")
+test_run:cmd("push filter 'peer_version_id: .*' to 'peer_version_id: <ID>'")
+test_run:cmd("push filter 'port: .*' to 'port: <PORT>'")
+
 test_run:cmd('create server connecter with script = "box/proxy.lua"')
 
 --
diff --git a/test/box/suite.ini b/test/box/suite.ini
index 7d0f0365b..e700d0b9e 100644
--- a/test/box/suite.ini
+++ b/test/box/suite.ini
@@ -56,7 +56,8 @@ fragile = {
             "issues": [ "gh-4998" ]
         },
         "net.box_reconnect_after_gh-3164.test.lua": {
-            "issues": [ "gh-5081" ]
+            "issues": [ "gh-5081" ],
+            "checksums": [ "a9dd14d22308797aaaeded75bddaae2a" ]
         },
         "net.box_disconnect_gh-3859.test.lua": {
             "issues": [ "gh-5156" ],
-- 
2.25.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test
  2020-12-08 16:19 [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test Alexander V. Tikhonov
@ 2020-12-10 15:38 ` Oleg Koshovetc
  2020-12-11  9:17 ` Kirill Yukhin
  1 sibling, 0 replies; 3+ messages in thread
From: Oleg Koshovetc @ 2020-12-10 15:38 UTC (permalink / raw)
  To: Alexander V. Tikhonov, Kirill Yukhin; +Cc: tarantool-patches

LGTM

NIT:

Regular expressions could be a bit stricter, especially "port: .*" one.

On 08.12.2020 19:19, Alexander V. Tikhonov via Tarantool-patches wrote:
> Cc: tarantool-patches@dev.tarantool.org
>
> Found issue:
>
>    [079] @@ -115,5 +115,14 @@
>    [079]  -- connection is deleted by 'collect'.
>    [079]  weak.c
>    [079]  ---
>    [079] -- null
>    [079] +- peer_uuid: 035d7b36-f205-45f4-9e16-e5b0b99a9b0b
>    [079] +  opts:
>    [079] +    reconnect_after: 0.1
>    [079] +  host: unix/
>    [079] +  schema_version: 78
>    [079] +  protocol: Binary
>    [079] +  state: error_reconnect
>    [079] +  error: Connection refused
>    [079] +  peer_version_id: 132864
>    [079] +  port: /tmp/tnt/079_box/proxy.socket-iproto
>    [079]  ...
>
> Which could not be restarted with checksum because of changing UUID
> value each run. To avoid of it added filter on 'peer_uuid:' output.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/box-test-filter
>
>   .../net.box_reconnect_after_gh-3164.result    | 20 +++++++++++++++++++
>   .../net.box_reconnect_after_gh-3164.test.lua  |  6 ++++++
>   test/box/suite.ini                            |  3 ++-
>   3 files changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/test/box/net.box_reconnect_after_gh-3164.result b/test/box/net.box_reconnect_after_gh-3164.result
> index 216ce0366..f28674bb6 100644
> --- a/test/box/net.box_reconnect_after_gh-3164.result
> +++ b/test/box/net.box_reconnect_after_gh-3164.result
> @@ -10,6 +10,26 @@ test_run = require('test_run').new()
>   net = require('net.box')
>   ---
>   ...
> +test_run:cmd("push filter 'peer_uuid: .*' to 'peer_uuid: <UUID>'")
> +---
> +- true
> +...
> +test_run:cmd("push filter 'reconnect_after: .*' to 'reconnect_after: <NUM>'")
> +---
> +- true
> +...
> +test_run:cmd("push filter 'schema_version: .*' to 'schema_version: <NUM>'")
> +---
> +- true
> +...
> +test_run:cmd("push filter 'peer_version_id: .*' to 'peer_version_id: <ID>'")
> +---
> +- true
> +...
> +test_run:cmd("push filter 'port: .*' to 'port: <PORT>'")
> +---
> +- true
> +...
>   test_run:cmd('create server connecter with script = "box/proxy.lua"')
>   ---
>   - true
> diff --git a/test/box/net.box_reconnect_after_gh-3164.test.lua b/test/box/net.box_reconnect_after_gh-3164.test.lua
> index dc2747080..085ce018f 100644
> --- a/test/box/net.box_reconnect_after_gh-3164.test.lua
> +++ b/test/box/net.box_reconnect_after_gh-3164.test.lua
> @@ -3,6 +3,12 @@ log = require 'log'
>   test_run = require('test_run').new()
>   net = require('net.box')
>   
> +test_run:cmd("push filter 'peer_uuid: .*' to 'peer_uuid: <UUID>'")
> +test_run:cmd("push filter 'reconnect_after: .*' to 'reconnect_after: <NUM>'")
> +test_run:cmd("push filter 'schema_version: .*' to 'schema_version: <NUM>'")
> +test_run:cmd("push filter 'peer_version_id: .*' to 'peer_version_id: <ID>'")
> +test_run:cmd("push filter 'port: .*' to 'port: <PORT>'")
> +
>   test_run:cmd('create server connecter with script = "box/proxy.lua"')
>   
>   --
> diff --git a/test/box/suite.ini b/test/box/suite.ini
> index 7d0f0365b..e700d0b9e 100644
> --- a/test/box/suite.ini
> +++ b/test/box/suite.ini
> @@ -56,7 +56,8 @@ fragile = {
>               "issues": [ "gh-4998" ]
>           },
>           "net.box_reconnect_after_gh-3164.test.lua": {
> -            "issues": [ "gh-5081" ]
> +            "issues": [ "gh-5081" ],
> +            "checksums": [ "a9dd14d22308797aaaeded75bddaae2a" ]
>           },
>           "net.box_disconnect_gh-3859.test.lua": {
>               "issues": [ "gh-5156" ],

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test
  2020-12-08 16:19 [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test Alexander V. Tikhonov
  2020-12-10 15:38 ` Oleg Koshovetc
@ 2020-12-11  9:17 ` Kirill Yukhin
  1 sibling, 0 replies; 3+ messages in thread
From: Kirill Yukhin @ 2020-12-11  9:17 UTC (permalink / raw)
  To: Alexander V. Tikhonov; +Cc: tarantool-patches

Hello,

On 08 Dec 19:19, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found issue:
> 
>   [079] @@ -115,5 +115,14 @@
>   [079]  -- connection is deleted by 'collect'.
>   [079]  weak.c
>   [079]  ---
>   [079] -- null
>   [079] +- peer_uuid: 035d7b36-f205-45f4-9e16-e5b0b99a9b0b
>   [079] +  opts:
>   [079] +    reconnect_after: 0.1
>   [079] +  host: unix/
>   [079] +  schema_version: 78
>   [079] +  protocol: Binary
>   [079] +  state: error_reconnect
>   [079] +  error: Connection refused
>   [079] +  peer_version_id: 132864
>   [079] +  port: /tmp/tnt/079_box/proxy.socket-iproto
>   [079]  ...
> 
> Which could not be restarted with checksum because of changing UUID
> value each run. To avoid of it added filter on 'peer_uuid:' output.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/box-test-filter

LGTM.
I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-11  9:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 16:19 [Tarantool-patches] [PATCH v1] test: add filter to box/net.*after_gh-3164 test Alexander V. Tikhonov
2020-12-10 15:38 ` Oleg Koshovetc
2020-12-11  9:17 ` Kirill Yukhin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox