Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v5] core: introduce evenly distributed int64 random in range
Date: Thu, 10 Dec 2020 21:45:09 +0300	[thread overview]
Message-ID: <20201210184509.GA21378@hpalx> (raw)
In-Reply-To: <20201210120048.GA1319@tarantool.org>

Hi All, thanks for the patch, as I see no new degradation found in
gitlab-ci testing commit criteria pipeline [1], patch LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/227898537

On Thu, Dec 10, 2020 at 12:00:48PM +0000, Nikita Pettik wrote:
> On 13 Nov 23:30, Vladislav Shpilevoy wrote:
> > LGTM.
> LGTM as well. Latest version rebased on master is on branch:
> https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5075-fine-random-in-range
> I see several CI fails (release_lto/ubuntu_19_10) but they seem to be
> unrelated to introduced changes. Aleksander, is it ok to push this patch
> to master?

  reply	other threads:[~2020-12-10 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 11:53 Ilya Kosarev
2020-11-13 22:30 ` Vladislav Shpilevoy
2020-12-10 12:00   ` Nikita Pettik
2020-12-10 18:45     ` Alexander V. Tikhonov [this message]
2020-12-11 12:04       ` Nikita Pettik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210184509.GA21378@hpalx \
    --to=avtikhon@tarantool.org \
    --cc=korablev@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v5] core: introduce evenly distributed int64 random in range' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox