From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BCDBA45C304 for ; Thu, 10 Dec 2020 21:45:12 +0300 (MSK) Date: Thu, 10 Dec 2020 21:45:09 +0300 From: "Alexander V. Tikhonov" Message-ID: <20201210184509.GA21378@hpalx> References: <20201113115318.16331-1-i.kosarev@tarantool.org> <3ff7ba65-993d-02df-9e54-6e35eb625ac8@tarantool.org> <20201210120048.GA1319@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210120048.GA1319@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5] core: introduce evenly distributed int64 random in range List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org Hi All, thanks for the patch, as I see no new degradation found in gitlab-ci testing commit criteria pipeline [1], patch LGTM. [1] - https://gitlab.com/tarantool/tarantool/-/pipelines/227898537 On Thu, Dec 10, 2020 at 12:00:48PM +0000, Nikita Pettik wrote: > On 13 Nov 23:30, Vladislav Shpilevoy wrote: > > LGTM. > > LGTM as well. Latest version rebased on master is on branch: > https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5075-fine-random-in-range > > I see several CI fails (release_lto/ubuntu_19_10) but they seem to be > unrelated to introduced changes. Aleksander, is it ok to push this patch > to master? >