From: Kirill Yukhin <kyukhin@tarantool.org>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix replication/skip_conflict_row output
Date: Thu, 10 Dec 2020 14:50:40 +0000 [thread overview]
Message-ID: <20201210145040.loo32w4dnll2zsti@tarantool.org> (raw)
In-Reply-To: <63c4da167efc9fd8151b8a144e651471915f4609.1607497400.git.avtikhon@tarantool.org>
Hello,
On 09 Dec 10:04, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
>
> Found that test replication/skip_conflict_row.test.lua fails with
> output message in results file:
>
> [260] @@ -117,11 +117,23 @@
> [260] -- lsn is not promoted
> [260] lsn1 == box.info.vclock[1]
> [260] ---
> [260] -- true
> [260] +- false
> [260] ...
> [260] test_run:wait_upstream(1, {status = 'stopped', message_re = "Duplicate key exists in unique index 'primary' in space 'test'"})
> [260] ---
> [260] -- true
> [260] +- false
> [260] +- id: 1
> [260] + uuid: bdbf6673-6ee4-47eb-a88d-81164f4e61c9
>
> Test could not be restarted with checksum because of changing values
> like UUID on each fail. It happend because test-run uses internal
> chain of functions wait_upstream() -> gen_box_info_replication_cond()
> which returns instance information on its fails. To avoid of it this
> output was redirected to log file instead of results file.
> ---
>
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/test-fix-skip-conflict
LGTM.
I've checked your patch into 1.10, 2.5, 2.6 and master.
--
Regards, Kirill Yukhin
prev parent reply other threads:[~2020-12-10 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 7:04 Alexander V. Tikhonov
2020-12-09 10:24 ` Oleg Koshovetc
2020-12-10 14:50 ` Kirill Yukhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201210145040.loo32w4dnll2zsti@tarantool.org \
--to=kyukhin@tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: fix replication/skip_conflict_row output' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox