Re: [Tarantool-patches] [PATCH v1] test: fix replication/skip_conflict_row output

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 09 Dec 10:04, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that test replication/skip_conflict_row.test.lua fails with
> output message in results file:
> 
>   [260] @@ -117,11 +117,23 @@
>   [260]  -- lsn is not promoted
>   [260]  lsn1 == box.info.vclock[1]
>   [260]  ---
>   [260] -- true
>   [260] +- false
>   [260]  ...
>   [260]  test_run:wait_upstream(1, {status = 'stopped', message_re = "Duplicate key exists in unique index 'primary' in space 'test'"})
>   [260]  ---
>   [260] -- true
>   [260] +- false
>   [260] +- id: 1
>   [260] +  uuid: bdbf6673-6ee4-47eb-a88d-81164f4e61c9
> 
> Test could not be restarted with checksum because of changing values
> like UUID on each fail. It happend because test-run uses internal
> chain of functions wait_upstream() -> gen_box_info_replication_cond()
> which returns instance information on its fails. To avoid of it this
> output was redirected to log file instead of results file.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/test-fix-skip-conflict

LGTM.

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin