From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 36D8145C304
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 10 Dec 2020 17:50:41 +0300 (MSK)
Date: Thu, 10 Dec 2020 14:50:40 +0000
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20201210145040.loo32w4dnll2zsti@tarantool.org>
References: <63c4da167efc9fd8151b8a144e651471915f4609.1607497400.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <63c4da167efc9fd8151b8a144e651471915f4609.1607497400.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] test: fix
	replication/skip_conflict_row output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 09 Dec 10:04, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that test replication/skip_conflict_row.test.lua fails with
> output message in results file:
> 
>   [260] @@ -117,11 +117,23 @@
>   [260]  -- lsn is not promoted
>   [260]  lsn1 == box.info.vclock[1]
>   [260]  ---
>   [260] -- true
>   [260] +- false
>   [260]  ...
>   [260]  test_run:wait_upstream(1, {status = 'stopped', message_re = "Duplicate key exists in unique index 'primary' in space 'test'"})
>   [260]  ---
>   [260] -- true
>   [260] +- false
>   [260] +- id: 1
>   [260] +  uuid: bdbf6673-6ee4-47eb-a88d-81164f4e61c9
> 
> Test could not be restarted with checksum because of changing values
> like UUID on each fail. It happend because test-run uses internal
> chain of functions wait_upstream() -> gen_box_info_replication_cond()
> which returns instance information on its fails. To avoid of it this
> output was redirected to log file instead of results file.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/test-fix-skip-conflict

LGTM.

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin