Re: [Tarantool-patches] [PATCH v1] test: move error messages into logs

[Kirill Yukhin <kyukhin@tarantool.org>]

Hello,

On 08 Dec 18:49, Alexander V. Tikhonov wrote:
> Cc: tarantool-patches@dev.tarantool.org
> 
> Found that some tests on fail use box.info* calls to print information,
> like:
> 
>   [024] --- replication/wal_rw_stress.result	Mon Nov 30 10:02:43 2020
>   [024] +++ var/rejects/replication/wal_rw_stress.reject	Sun Dec  6 16:06:46 2020
>   [024] @@ -77,7 +77,45 @@
>   [024]              r.downstream.status ~= 'stopped')    \
>   [024]  end) or box.info
>   [024]  ---
>   [024] -- true
>   [024] +- version: 2.7.0-109-g0b3ad5d8a0
>   [024] +  id: 2
>   [024] +  ro: false
>   [024] +  uuid: e0b8863f-7b50-4eb5-947f-77f92c491827
> 
> It denies test-run from rerunng these tests using checksums, because
> of changing output on each fail, like 'version:' either 'uuid:' fields
> values above. To avoid of it, these calls outputs should be redirected
> to log files using log.error(). Also the same fix made for tests with
> fio.listdir() and fio.stat() on errors.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/tests-output-to-logs

I've checked your patch into 1.10, 2.5, 2.6 and master.

--
Regards, Kirill Yukhin